public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Aleksander Alekseev <[email protected]>
To: pgsql-hackers <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: jian he <[email protected]>
Cc: vignesh C <[email protected]>
Subject: Re: Catalog domain not-null constraints
Date: Wed, 20 Mar 2024 10:41:33 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAJ7c6TOLjH8mMxaVPPPyy0qAVGQ6jCs5P2ggNZcSQvz+deN-bA@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<CAJ7c6TOLjH8mMxaVPPPyy0qAVGQ6jCs5P2ggNZcSQvz+deN-bA@mail.gmail.com>

On 18.03.24 11:02, Aleksander Alekseev wrote:
> Hi,
> 
>> Anyway, in order to move this forward, here is an updated patch where
>> the ADD CONSTRAINT ... NOT NULL behavior for domains matches the
>> idempotent behavior of tables.  This uses the patch that Jian He posted.
> 
> I tested the patch on Raspberry Pi 5 and Intel MacBook and also
> experimented with it. Everything seems to work properly.
> 
> Personally I believe new functions such as
> validateDomainNotNullConstraint() and findDomainNotNullConstraint()
> could use a few lines of comments (accepts..., returns..., etc).

Done.

> Also
> I think that the commit message should explicitly say that supporting
> NOT VALID constraints is out of scope of this patch.

Not done.  I don't know what NOT VALID has to do with this.  This patch 
just changes the internal catalog representation, it doesn't claim to 
add or change any features.  The documentation already accurately states 
that NOT VALID is not supported for NOT NULL constraints.

> Except for named nitpicks v4 LGTM.

Committed, thanks.

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Catalog domain not-null constraints
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox