Feedback-ID: i1ff147bf:Fastmail
From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Aleksander Alekseev <aleksander@tigerdata.com>,  pgsql-hackers
 <pgsql-hackers@postgresql.org>,  Andrey Borodin <x4mmm@yandex-team.ru>
Subject: Re: Add uuid_to_base32hex() and base32hex_to_uuid() built-in
 functions
References: <1791665551.452444.1761209220211.ref@mail.yahoo.com>
	<1895971769.8343.1761240853939@mail.yahoo.com>
	<CAD21AoCxy_3VW2_z5Rxc-tFsuqeyGsA-F_kD-tx6XXBC56nTCg@mail.gmail.com>
	<574624399.175025.1761290201491@mail.yahoo.com>
	<CAD21AoAXQcZ2mMkxX6NPdFpdC-D3AhE--qyH9Se3XTrDX6x-bg@mail.gmail.com>
	<953203149.383019.1761345585325@mail.yahoo.com>
	<CAD21AoCzEDdwpyPwA0d-QmCRe5rMz3m160SJgxMwKke85e8n0w@mail.gmail.com>
	<6F76FA61-E2DC-44EF-9504-889D9BDB4EBD@yandex-team.ru>
	<CAD21AoCKvYCccndY4CRcwk1bOuWxJionOidEtKQWoJTqS7wL1g@mail.gmail.com>
	<1154454839.957923.1761604611424@mail.yahoo.com>
	<CAGECzQTb9pg2Qw0XmOEKaJivLJ8kdGq3Cq38OqSgwiFVD=9f8A@mail.gmail.com>
	<87ldkv8cog.fsf@wibble.ilmari.org> <87ikfz7zcu.fsf@wibble.ilmari.org>
	<CAD21AoCf-0LdE=Js3ViXmKfSATJOjSNym1+80O+=-Y3X6LDMyA@mail.gmail.com>
	<9CB824CC-70DC-4165-AC6A-9664F47209EE@yandex-team.ru>
	<aa24964a-f0d7-435e-9254-bb69823948d6@gmail.com>
	<CAJ7c6TNCGT2eZ8JttAZKUhVv3jJFTHvjFw6typzSGkM5_vePow@mail.gmail.com>
	<CAJ7c6TMZOvVcbEZ-KH8e4mDuQ6ZTfgV-BJoLX_aTd1MtjScyqA@mail.gmail.com>
	<CAD21AoCcikUgU5coyvM7PLJg5M-75LzQhm-Uxmqn_7M=DHkj+w@mail.gmail.com>
	<CAJ7c6TPu7NGrSj-V2-ns0GTNGx9cmoKQgzt-p2MpJepiGjQnYw@mail.gmail.com>
	<CAD21AoC2Ooy=W=4YjQ_GO5nEYZ2tsn43=TkLf7ysE-96ygohKg@mail.gmail.com>
Date: Thu, 19 Mar 2026 14:36:04 +0000
In-Reply-To: 
 <CAD21AoC2Ooy=W=4YjQ_GO5nEYZ2tsn43=TkLf7ysE-96ygohKg@mail.gmail.com>
	(Masahiko Sawada's message of "Wed, 18 Mar 2026 10:52:30 -0700")
Message-ID: <878qbn51kb.fsf@wibble.ilmari.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Archived-At: 
 <https://www.postgresql.org/message-id/878qbn51kb.fsf%40wibble.ilmari.org>
Precedence: bulk

Masahiko Sawada <sawada.mshk@gmail.com> writes:

> I've made some minor changes to both patches (e.g., rewording the
> documentation changes and commit messages etc), and attached the
> updated patches.
>
> I'm going to push these patches unless there is no further comment.

Just one minor nitpick on my patch, which is that it should use
palloc_object(), which I wasn't aware of when I wrote it originally.

> diff --git a/src/backend/utils/adt/bytea.c b/src/backend/utils/adt/bytea.c
> index fd7662d41ee..4dc83671aa5 100644
> --- a/src/backend/utils/adt/bytea.c
> +++ b/src/backend/utils/adt/bytea.c
[...]
> +	if (len != UUID_LEN)
> +		ereport(ERROR,
> +				(errcode(ERRCODE_INVALID_BINARY_REPRESENTATION),
> +				 errmsg("invalid input length for type %s", "uuid"),
> +				 errdetail("Expected %d bytes, got %d.", UUID_LEN, len)));
> +
> +	uuid = (pg_uuid_t *) palloc(sizeof(pg_uuid_t));

this should be:

+	uuid = palloc_object(pg_uuid_t);

> +	memcpy(uuid->data, VARDATA_ANY(v), UUID_LEN);
> +	PG_RETURN_UUID_P(uuid);
> +}
> +


- ilmari