Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vHQ6t-006xNA-OC for pgsql-hackers@arkaria.postgresql.org; Fri, 07 Nov 2025 17:18:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1vHQ6s-00FqhV-Bi for pgsql-hackers@arkaria.postgresql.org; Fri, 07 Nov 2025 17:18:50 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vHQ6r-00FqhN-IX for pgsql-hackers@lists.postgresql.org; Fri, 07 Nov 2025 17:18:50 +0000 Received: from fout-a2-smtp.messagingengine.com ([103.168.172.145]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vHQ6o-006Wog-2g for pgsql-hackers@lists.postgresql.org; Fri, 07 Nov 2025 17:18:49 +0000 Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfout.phl.internal (Postfix) with ESMTP id 7D61DEC049B; Fri, 7 Nov 2025 12:18:44 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Fri, 07 Nov 2025 12:18:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilmari.org; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1762535924; x=1762622324; bh=zpKNZQ0u3a tBeVHZ4ldKSj6iC182qntdFFtix+qiUco=; b=HdK+SmseBuEGULgu3Tw3sFe4Tm jTU+2vDdJc5I95SvYDHGAOLiBkEnInkUX8K6ZWQXd6qej1LPWHVUuyp2vMNlyHKh Nc+M9Sw/QbWW5wQSyVih8wVrfiX8jY07JjI9LUJ3AxQANurYM7UNbSZF7pVFOeKN pgz7BwlAaayTy0OJt6TAdOuW5v6pmQR3u9VhuJIKhyWlsTj8yL0/m1FF4ExlQHZC AZtqavXwIwvmrzW0nz0it2s4l01Ta5EKuwVKRl8Q5WnJquifWi2tm7GuJTjjIi8T EDoagS2OpaZ+jtvkYu0zirieTby3R+CGhj4cGq78w0ugmYsq123mIh18M87A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1762535924; x=1762622324; bh=zpKNZQ0u3atBeVHZ4ldKSj6iC182qntdFFt ix+qiUco=; b=WPmvh8AB/tX7/avQkg4Hspo1GnAArl5QsAPeKOlC4xLG4L8ffqV Ah+KVYjl8jGOF7KyRMnGp0b8LeBm+SRMq7apzYv6spakeEv+AjYPjYSGHo1IVsUv HFiIJxMabcWtKmsMzBc0a5ug6qBMivkyCh7WEzp/BJve0pY0mma5h3WVm6eEWtM3 JLAO88W2O2En3YRwh1bA7D6SkbzPJLTXigBkq370c/35sspf4syEWCmavgRxjgRC 4zVh82CEWT6+EmFMgXKKHbt/ZTG5rcgty2L/Ato4FkJP334wWRLByrMFR9Gxt146 wrBzwsbFNIUGfYDhIg0Lk1FNgx7X73LY2Tg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdduledtvdegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefufhffjgfkfgggtgesthdtredttderjeenucfhrhhomhepffgrghhfihhn nhcukfhlmhgrrhhiucforghnnhhsnohkvghruceoihhlmhgrrhhisehilhhmrghrihdroh hrgheqnecuggftrfgrthhtvghrnhepkeeljeeufefhffekhfektdefleeuvdeiiefhheef feefgeegudffudehjeejiefgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepihhlmhgrrhhisehilhhmrghrihdrohhrghdpnhgspghrtghpthht ohepjedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepphhgshhqlhdqhhgrtghkvg hrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdhorhhgpdhrtghpthhtohepqhhurghn iihonhhglhhirghngheshigvrghhrdhnvghtpdhrtghpthhtohephhhlihhnnhgrkhgrse hikhhirdhfihdprhgtphhtthhopehmihgthhgrvghlsehprghquhhivghrrdighiiipdhr tghpthhtoheprghlvhhhvghrrhgvsehkuhhrihhlvghmuhdruggvpdhrtghpthhtohepsg gvrhhtrhgrnhguughrohhuvhhothdrphhgsehgmhgrihhlrdgtohhmpdhrtghpthhtohep phgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhg X-ME-Proxy: Feedback-ID: i1ff147bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 7 Nov 2025 12:18:42 -0500 (EST) From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= To: Peter Eisentraut Cc: Bertrand Drouvot , =?utf-8?Q?=C3=81lvar?= =?utf-8?Q?o?= Herrera , Michael Paquier , Heikki Linnakangas , Quan Zongliang , pgsql-hackers@lists.postgresql.org Subject: Re: Consistently use the XLogRecPtrIsInvalid() macro References: <202511071335.iw4fygwd4rxo@alvherre.pgsql> <2d6e23db-f2f8-44ce-ad7a-258612dd6409@eisentraut.org> Date: Fri, 07 Nov 2025 17:18:41 +0000 In-Reply-To: <2d6e23db-f2f8-44ce-ad7a-258612dd6409@eisentraut.org> (Peter Eisentraut's message of "Fri, 7 Nov 2025 17:05:11 +0100") Message-ID: <87a50x92xa.fsf@wibble.ilmari.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Eisentraut writes: > On 07.11.25 16:03, Bertrand Drouvot wrote: > >> +#define pg_attribute_deprecated(msg) [[deprecated(msg)]] >> +#elif defined(__GNUC__) || defined(__clang__) > > The __clang__ part is not needed, because clang defines __GNUC__ also. Or, to avoid having to know this, how about __has_attribute(deprecated)? - ilmari