Feedback-ID: i1ff147bf:Fastmail
From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
To: px shi <spxlyy123@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: CREATE MATERIALIZED VIEW
References: <CAAccyY+Wg1Z-9tNfSwLmuZVgGOwqU5u1OP-RWcoAr2UZGuvN_w@mail.gmail.com>
	<87cyn1eft4.fsf@wibble.ilmari.org>
Date: Thu, 25 Jul 2024 15:09:09 +0100
In-Reply-To: <87cyn1eft4.fsf@wibble.ilmari.org> ("Dagfinn Ilmari
 =?utf-8?Q?Manns=C3=A5ker=22's?=
	message of "Thu, 25 Jul 2024 14:56:07 +0100")
Message-ID: <87a5i5ef7e.fsf@wibble.ilmari.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Archived-At: <https://www.postgresql.org/message-id/87a5i5ef7e.fsf%40wibble.ilmari.org>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> writes:

> px shi <spxlyy123@gmail.com> writes:
>
>> Hi, I see that materialized view cannot be unlogged now, but when I use
>> psql and type CREATE UNLOGGED, pressing the Tab key for auto-completion
>> suggests `TABLE` and MATERIALIZED VIEW.
>> Shouldn't `MATERIALIZED VIEW ` be suggested?
>
> That's my fault, I added it in commit c951e9042dd1, presumably because
> the grammar allows it, but it turns transformCreateTableAsStmt() rejects
> it.

Scratch that, I misread the diff. The tab completion has been there
since matviews were added in commit 3bf3ab8c5636, but the restriction on
unlogged matviews was added later in commit 3223b25ff73, which failed to
update the tab completion code to match.

Here's a updated patch with a corrected commit message.

- ilmari


--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
 filename=v2-0001-Don-t-tab-complete-MATERIALIZED-VIEW-after-CREATE.patch

From 58aebeda0c2161598b58f468d3c46b113651fb79 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dagfinn=20Ilmari=20Manns=C3=A5ker?= <ilmari@ilmari.org>
Date: Thu, 25 Jul 2024 14:33:14 +0100
Subject: [PATCH v2] Don't tab complete MATERIALIZED VIEW after CREATE UNLOGGED

When materialized views were originally added in commit 3bf3ab8c5636,
they could be unlogged, so the tab completion was added. However, when
commit 3223b25ff73 banned them, the tab completion was not updated to
match.
---
 src/bin/psql/tab-complete.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
index 891face1b6..024469474d 100644
--- a/src/bin/psql/tab-complete.c
+++ b/src/bin/psql/tab-complete.c
@@ -3267,15 +3267,9 @@ psql_completion(const char *text, int start, int end)
 	/* Complete "CREATE TEMP/TEMPORARY" with the possible temp objects */
 	else if (TailMatches("CREATE", "TEMP|TEMPORARY"))
 		COMPLETE_WITH("SEQUENCE", "TABLE", "VIEW");
-	/* Complete "CREATE UNLOGGED" with TABLE, SEQUENCE or MATVIEW */
+	/* Complete "CREATE UNLOGGED" with TABLE or SEQUENCE */
 	else if (TailMatches("CREATE", "UNLOGGED"))
-	{
-		/* but not MATVIEW in CREATE SCHEMA */
-		if (HeadMatches("CREATE", "SCHEMA"))
-			COMPLETE_WITH("TABLE", "SEQUENCE");
-		else
-			COMPLETE_WITH("TABLE", "SEQUENCE", "MATERIALIZED VIEW");
-	}
+		COMPLETE_WITH("TABLE", "SEQUENCE");
 	/* Complete PARTITION BY with RANGE ( or LIST ( or ... */
 	else if (TailMatches("PARTITION", "BY"))
 		COMPLETE_WITH("RANGE (", "LIST (", "HASH (");
-- 
2.39.2


--=-=-=--