Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ge5FH-00015b-SL for pgsql-hackers@arkaria.postgresql.org; Mon, 31 Dec 2018 21:37:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ge5EH-00054x-PJ for pgsql-hackers@arkaria.postgresql.org; Mon, 31 Dec 2018 21:36:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ge5EH-00054q-IT for pgsql-hackers@lists.postgresql.org; Mon, 31 Dec 2018 21:36:09 +0000 Received: from lungold.riddles.org.uk ([82.68.208.19]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ge5EB-0002jj-2f for pgsql-hackers@postgresql.org; Mon, 31 Dec 2018 21:36:09 +0000 Received: from [192.168.127.1] (port=11377 helo=caithnard.riddles.org.uk) by lungold.riddles.org.uk with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.88 (FreeBSD)) (envelope-from ) id 1ge5E6-0001fU-Jx; Mon, 31 Dec 2018 21:35:58 +0000 Received: from [127.0.0.1] (port=58997 helo=caithnard.riddles.org.uk) by caithnard.riddles.org.uk with esmtp (Exim 4.89 (FreeBSD)) (envelope-from ) id 1ge5E5-000C7z-OM; Mon, 31 Dec 2018 21:35:57 +0000 From: Andrew Gierth To: Alvaro Herrera Cc: Stephen Frost , Peter Eisentraut , Sergei Kornilov , Michael Paquier , Andreas Karlsson , PostgreSQL mailing lists , Craig Ringer Subject: Re: [HACKERS] REINDEX CONCURRENTLY 2.0 In-Reply-To: <201812312116.pavh6ts5qeum@alvherre.pgsql> (Alvaro Herrera's message of "Mon, 31 Dec 2018 18:16:50 -0300") Message-ID: <87a7kltmbt.fsf@news-spur.riddles.org.uk> References: <201812312116.pavh6ts5qeum@alvherre.pgsql> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (berkeley-unix) Date: Mon, 31 Dec 2018 21:35:57 +0000 MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk >>>>> "Alvaro" == Alvaro Herrera writes: Alvaro> After looking at the proposed grammar again today and in danger Alvaro> of repeating myself, IMO allowing the concurrency keyword to Alvaro> appear outside the parens would be a mistake. Valid commands: Alvaro> REINDEX (VERBOSE, CONCURRENTLY) TABLE foo; Alvaro> REINDEX (CONCURRENTLY) INDEX bar; We burned that bridge with CREATE INDEX CONCURRENTLY; to make REINDEX require different syntax would be too inconsistent. If we didn't have all these existing uses of CONCURRENTLY without parens, your argument might have more merit; but we do. -- Andrew (irc:RhodiumToad)