From: "Jonathan Gonzalez V." <jonathan.abdiel@gmail.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Chao Li <li.evan.chao@gmail.com>,  Euler Taveira <euler@eulerto.com>,
  japin <japinli@hotmail.com>,  Andres Freund <andres@anarazel.de>,
  pgsql-hackers@lists.postgresql.org
Subject: Re: log_min_messages per backend type
In-Reply-To: <al4PzUn6y82eP-t1@alvherre.pgsql> (Alvaro Herrera's message of
	"Mon, 20 Jul 2026 14:15:36 +0200")
References: <al4PzUn6y82eP-t1@alvherre.pgsql>
Date: Tue, 21 Jul 2026 11:39:41 +0200
Message-ID: <87bjc0heaq.fsf@gmail.com>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Archived-At: 
 <https://www.postgresql.org/message-id/87bjc0heaq.fsf%40gmail.com>
Precedence: bulk

Hello!


Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Hello,
>
> Here's a couple of trivial cleanups of this code.  0001 simplifies code
> and removes a duplicate by creating a small subroutine; 0002 also
> simplifies memory freeing a tad, by freeing allocations as soon as
> no longer needed instead of waiting and being forced to duplicate the
> frees in several places.
>
> This is two commits here just for ease of review, but I'd probably push
> as one commit (and without backpatch).

The first commit passed without problems and works like a charm, but the
second one is breaking the detection of the messages here:

@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
                guc_free(rawstring);
                return false;
        }
+       rawstring_len = strlen(rawstring);
+       guc_free(rawstring);


The rawstring is being reference in the elemlist, so the free is making
the string empty when is going to be used later:

(gdb) print rawstring
$17 = 0x555556f85e08 ""
(gdb) print *elemlist->elements
$18 = {
  ptr_value = 0x555556f85e08,
  int_value = 1459117576,
  oid_value = 1459117576,
  xid_value = 1459117576
}

Regards!
--
Jonathan Gonzalez V.
EDB
https://www.enterprisedb.com