Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qFAVR-0007bK-Vj for pgsql-hackers@arkaria.postgresql.org; Fri, 30 Jun 2023 09:33:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qFAVQ-0008TI-PO for pgsql-hackers@arkaria.postgresql.org; Fri, 30 Jun 2023 09:33:32 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qFAVP-0008T9-C6 for pgsql-hackers@lists.postgresql.org; Fri, 30 Jun 2023 09:33:32 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qFAVM-001Fwl-1t for pgsql-hackers@lists.postgresql.org; Fri, 30 Jun 2023 09:33:30 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id E21453200A11; Fri, 30 Jun 2023 05:33:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 30 Jun 2023 05:33:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilmari.org; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1688117605; x=1688204005; bh=V0 vbLwmMaNSTCou1kr5+B0Wi+KF33kq1H1SnnbkcReI=; b=I+XtteuRLPS8jbBkyR C8HX66DrQ4KW+grTUchP/BU7hh0w/yBj9fTGfxB1VrXcnhM3klEE/OVI3rEoANE5 BMJZv/qZwy5Hbwez0VQ7nN48AqimNMI6jhJfnrARBqM9HtkUHKxnH+LrRkn3ioV6 sZOiJE0iC3+5yDRPQH8rdGZr132awECDGZHURfRv3/F+lJBtkCkOXp9EowZV0B4G 6hkMQtE9nCw/Ut7ZASVvQMbxoNYoRVBDlibFs63qAcioSpqxZoa4k8eP/UvyZLye cgCdkSZjiOF9syjEOw4BEFzH1nF1jHcEwYabVj89tA2+S6W9sqCNFxtZfcLYMjo8 SU7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1688117605; x=1688204005; bh=V0vbLwmMaNSTC ou1kr5+B0Wi+KF33kq1H1SnnbkcReI=; b=n2n2iHKyET7Uz4DWf/iKEkuzLcE9q m/WjZDyLUtpd32gO9rKOPGfmyqfWFO+8J2y4m4sue+VIh6i56qbZPwUpGLkN6nkw HAoHrThEhTcUb+e/M6ttdCsKu1mvxJNELluFfV3dFVsuZKaMsvXOgVaZi6SX8IJ1 OFYBQWVqaAkIPMZrxH9Kko5XIoV+74hqrZxL9YXmfDte7N8czk8gn2W5uSXr9VTL l6oZ7nU6G+LQFA1A6mHJE+tPx6gHaWMDmyfYL8IPc3Hc1cOyKUWKG3TxY2F3Mpw3 WM/NG/yRpjXhFYTa7RPSxXvD33K82p190KyqYZYySv55LVsGVELe1mzRA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrtdeigdduiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdefhedmnecujfgurhephffvvefufhffjgfkfgggtgesthdtredttder jeenucfhrhhomhepffgrghhfihhnnhcukfhlmhgrrhhiucforghnnhhsnohkvghruceoih hlmhgrrhhisehilhhmrghrihdrohhrgheqnecuggftrfgrthhtvghrnhepkeeljeeufefh ffekhfektdefleeuvdeiiefhheeffeefgeegudffudehjeejiefgnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihhlmhgrrhhisehilhhmrghr ihdrohhrgh X-ME-Proxy: Feedback-ID: i1ff147bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Jun 2023 05:33:24 -0400 (EDT) From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= To: Michael Paquier Cc: Suraj Khamkar , pgsql-hackers@lists.postgresql.org Subject: Re: Tab completion for CREATE SCHEMAAUTHORIZATION References: <87ildyqwks.fsf@wibble.ilmari.org> <875y9buhys.fsf@wibble.ilmari.org> <87354fudqy.fsf@wibble.ilmari.org> <87ttwmu6es.fsf@wibble.ilmari.org> Date: Fri, 30 Jun 2023 10:33:22 +0100 In-Reply-To: (Michael Paquier's message of "Fri, 30 Jun 2023 10:36:47 +0900") Message-ID: <87bkgxqopp.fsf@wibble.ilmari.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Michael Paquier writes: > On Tue, May 09, 2023 at 12:26:16PM +0900, Michael Paquier wrote: >> That looks pretty much OK to me. One tiny comment I have is that this >> lacks brackets for the inner blocks, so I have added some in the v4 >> attached. > > The indentation was a bit wrong, so fixed it, and applied on HEAD. Thanks! - ilmari