Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khfC0-0000uo-Ly for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Nov 2020 20:45:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1khfBz-0001VM-KS for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Nov 2020 20:45:39 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khfBz-0001V5-Dr for pgsql-hackers@lists.postgresql.org; Tue, 24 Nov 2020 20:45:39 +0000 Received: from lungold.riddles.org.uk ([82.68.208.19]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khfBx-0004ug-6f for pgsql-hackers@lists.postgresql.org; Tue, 24 Nov 2020 20:45:38 +0000 Received: from [192.168.127.1] (port=42453 helo=caithnard.riddles.org.uk) by lungold.riddles.org.uk with esmtp (Exim 4.92.3 (FreeBSD)) (envelope-from ) id 1khfBt-000LLv-Bf; Tue, 24 Nov 2020 20:45:33 +0000 Received: from localhost ([127.0.0.1]:18897 helo=caithnard.riddles.org.uk) by caithnard.riddles.org.uk with esmtp (Exim 4.93.0.4 (FreeBSD)) (envelope-from ) id 1khfBt-0005Kd-6p; Tue, 24 Nov 2020 20:45:33 +0000 From: Andrew Gierth To: Tom Lane Cc: pgsql-hackers@lists.postgresql.org, kes-kes@yandex.ru Subject: Re: mark/restore failures on unsorted merge joins In-Reply-To: <296182.1606247286@sss.pgh.pa.us> (Tom Lane's message of "Tue, 24 Nov 2020 14:48:06 -0500") Message-ID: <87blfm4hdv.fsf@news-spur.riddles.org.uk> References: <87o8jn50be.fsf@news-spur.riddles.org.uk> <125707.1606161260@sss.pgh.pa.us> <87k0ua4p4u.fsf@news-spur.riddles.org.uk> <293167.1606242810@sss.pgh.pa.us> <87ft4y4lxm.fsf@news-spur.riddles.org.uk> <296182.1606247286@sss.pgh.pa.us> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (berkeley-unix) Date: Tue, 24 Nov 2020 20:45:33 +0000 MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk >>>>> "Tom" == Tom Lane writes: >> I guess that's close enough; this should suffice then. Tom> Looks about right. Not sure if we need to bother with a regression Tom> test case; once that's in, it'd be hard to break it. We could check the EXPLAIN output (since the Materialize node would show up), but it's not easy to get stable plans since the choice of which path to put on the outside is not fixed. Based on what I found when actually testing the code, it probably wouldn't be worth the effort. -- Andrew (irc:RhodiumToad)