Message-ID: <87e93704-b7f7-71f6-161d-8713e6334ed3@enterprisedb.com>
Date: Thu, 27 Jan 2022 09:10:46 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.0
Subject: Re: ICU for global collation
Content-Language: en-US
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>,
 Daniel Verite <daniel@manitou-mail.org>
References: <20220110032508.4eyz6m6mpvt622la@jrouhaud>
 <20220110060027.egvaly4lskylo22f@jrouhaud>
 <c3093547-6ce2-66ca-71de-3a3c633cfb02@enterprisedb.com>
 <20220111110852.t5oxfga57llm5cy2@jrouhaud>
 <a6f807c2-2d11-2cf6-a524-cfbec56e7d5b@enterprisedb.com>
 <20220118040246.dewl5pain2gkv2iv@jrouhaud>
 <171c5f7c-43ee-dbe9-31f9-5e3eb06a54cf@enterprisedb.com>
 <e381e36c-c7a2-2ec0-dbb4-da1dab3f0941@enterprisedb.com>
 <20220121135119.ywszwl4353v5dzh5@jrouhaud>
 <e2061949-f731-fd60-8b0b-3bae75095b4f@enterprisedb.com>
 <20220121161331.xn7fhtfg5j2ucilb@jrouhaud>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20220121161331.xn7fhtfg5j2ucilb@jrouhaud>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/87e93704-b7f7-71f6-161d-8713e6334ed3%40enterprisedb.com>
Precedence: bulk

On 21.01.22 17:13, Julien Rouhaud wrote:
> On Fri, Jan 21, 2022 at 03:24:02PM +0100, Peter Eisentraut wrote:
>> On 21.01.22 14:51, Julien Rouhaud wrote:
>>> Is that change intended?  There isn't any usage of the collversionstr before
>>> the possible error when actual_versionstr is missing.
>>
>> I wanted to move it closer to the SysCacheGetAttr() where the "datum" value
>> is obtained.  It seemed weird to get the datum, then do other things, then
>> decode the datum.
> 
> Oh ok.  It won't make much difference performance-wise, so no objection.

I have committed this and will provide follow-up patches in the next few 
days.