Feedback-ID: i1ff147bf:Fastmail
From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,  Peter Smith
 <smithpb2250@gmail.com>,  PostgreSQL Hackers
 <pgsql-hackers@lists.postgresql.org>
Subject: Re: TAP test command_fails versus command_fails_like
References: <CAHut+Pu-umU=CkcSvrqL9eQt85Rv_qfLtekqU-yrjfh=GirUQg@mail.gmail.com>
	<CAExHW5vMkqvgxXOveB0_uRjYiCY319HK83Y-ErehcLyE0yv9Ww@mail.gmail.com>
	<87h64z2rk7.fsf@wibble.ilmari.org>
	<419ce961-fda6-4b24-b5c2-fde414065c70@dunslane.net>
Date: Wed, 12 Feb 2025 16:58:47 +0000
In-Reply-To: <419ce961-fda6-4b24-b5c2-fde414065c70@dunslane.net> (Andrew
	Dunstan's message of "Wed, 12 Feb 2025 10:40:25 -0500")
Message-ID: <87ed032j7c.fsf@wibble.ilmari.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/87ed032j7c.fsf%40wibble.ilmari.org>
Precedence: bulk

Andrew Dunstan <andrew@dunslane.net> writes:

> On 2025-02-12 We 8:58 AM, Dagfinn Ilmari Mannsåker wrote:
>>
>>> Another question is whether command_fails and command_fails_like is
>>> the only pair or there are more which need stricter checks?
>> If we do this, we should do it across the board for
>> PostgreSQL::Test::Utils and ::Cluster at least.  Once we bump the
>> minimum perl version to 5.20 or beyond we should switch to using
>> function signatures (https://perldoc.perl.org/perlsub#Signatures), which
>> gives us this checking for free.
>
> Is there any reason we can't move to 5.20? Are there any buildfarm
> animals using such an old version? 5.20 is now almost 10 years old.

Red Hat Enterprise Linux 7 has Perl 5.16 and is on Extended Lifecycle
Support until 2028-06-30. I don't know how long other distros based on
that (e.g. CentOS, Scientific Linux) are supported, but I can see that
Amazon Linux 2 is almost out of support (2025-06-30).

> cheers
>
> andrew

- ilmari