Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rthjr-00GrBl-QQ for pgsql-hackers@arkaria.postgresql.org; Mon, 08 Apr 2024 05:40:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rthjq-000nKc-Nt for pgsql-hackers@arkaria.postgresql.org; Mon, 08 Apr 2024 05:40:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rthjq-000nIu-EE for pgsql-hackers@lists.postgresql.org; Mon, 08 Apr 2024 05:40:14 +0000 Received: from m15.mail.163.com ([45.254.50.220]) by makus.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rthjk-001lnv-IX for pgsql-hackers@lists.postgresql.org; Mon, 08 Apr 2024 05:40:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version: Content-Type; bh=U2avf092GVXmoY+oAi7CpKwVrojxyXjrD+ikgiuGmcU=; b=F36tMDGGQTJiPcCUEFrRQbaRyChaJgFwHIauIZNuqsW2hcNHymA4HKEKBd3K7N T3NXAFujHQxBFD5IIG0cvLijWGCsqI6KM64jJkmQRcuvA0Hdty9UIPWd8FYEId70 p/zUscMeCGVtUwGkLVwha48wjSCJeohxHhMn/HnZHZENI= Received: from 8235eee8a2a0 (unknown [140.205.118.36]) by gzga-smtp-mta-g0-2 (Coremail) with SMTP id _____wD3X8grgxNmCNLGAQ--.17039S3; Mon, 08 Apr 2024 13:39:56 +0800 (CST) References: <87il0smqa9.fsf@163.com> User-agent: mu4e 1.10.7; emacs 29.1 From: Andy Fan To: Michael Paquier Cc: PostgreSQL-development , Tomas Vondra , pgsql-hackers@lists.postgresql.org Subject: Re: Replace FunctionCall2Coll with FunctionCallInvoke Date: Mon, 08 Apr 2024 13:36:20 +0800 In-reply-to: Message-ID: <87edbgmmz8.fsf@163.com> MIME-Version: 1.0 Content-Type: text/plain X-CM-TRANSID:_____wD3X8grgxNmCNLGAQ--.17039S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrKFyrCw1xKw45JFWfAFyDGFg_yoW3XFgE9F s0ya9xXr43Ar4xKan2yrn0yrs8Wr4q9rWj9F4rXry29Fy5A39xWFWkur98u3Z7Gr40yr98 GrZrGr12gwsrCjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xR_T5l7UUUUU== X-Originating-IP: [140.205.118.36] X-CM-SenderInfo: x2klx3xlid0iqsrtqiywtou0bp/1tbiVA+6U2VOCP5yEwAAsO List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hello Michael, > [[PGP Signed Part:Undecided]] > On Mon, Apr 08, 2024 at 12:25:00PM +0800, Andy Fan wrote: >> During the review of using extended statistics to improve join estimates >> [1], I found some code level optimization opportunities which apply to >> existing code as well. To make the discussion easier, open this new >> thread. > > Is that measurable? I didn't spent time on testing it. Compared with if the improvement is measureable, I'm more interested with if it is better than before or not. As for measurable respect, I'm with the idea at [1]. Do you think the measurable matter? [1] https://www.postgresql.org/message-id/CA%2BTgmoZJ0a_Dcn%2BST4YSeSrLnnmajmcsi7ZvEpgkKNiF0SwBuw%40mail.gmail.com -- Best Regards Andy Fan