Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uQcE5-00ET52-G5 for pgsql-hackers@arkaria.postgresql.org; Sun, 15 Jun 2025 01:32:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uQcE3-00B47w-Bm for pgsql-hackers@arkaria.postgresql.org; Sun, 15 Jun 2025 01:32:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uQcE3-00B47o-21 for pgsql-hackers@lists.postgresql.org; Sun, 15 Jun 2025 01:31:59 +0000 Received: from m16.mail.163.com ([220.197.31.5]) by magus.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1uQcDy-0026WS-0L for pgsql-hackers@lists.postgresql.org; Sun, 15 Jun 2025 01:31:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version: Content-Type; bh=aMEkErFZktKfo9M7nmz48t0bjibeaotYmoj3R6aDm5Q=; b=Hxq27amEz5n+BkWRPOqs00bBezkOkvIO+ZSFsUvt2W5308K4ZN2mBU4po2XGp1 A/Tiic5yT/yNgBshj/1yxEjcuRbeCHCNG/Cza6U/+O/adzW19iUNNChqT88HGa55 r3wedftrDZr2MYqBEeyQhIBrf9Hvpbk0XYSdX8QoKuaNA= Received: from lovely-coding (unknown []) by gzga-smtp-mtada-g1-2 (Coremail) with SMTP id _____wA37C5_Ik5om8IVIQ--.908S3; Sun, 15 Jun 2025 09:31:44 +0800 (CST) From: Andy Fan To: Jesper Pedersen Cc: Nathan Bossart , Tomas Vondra , John Naylor , "Devulapalli, Raghuveer" , "pgsql-hackers@lists.postgresql.org" , "Shankaran, Akash" , Tomas Vondra Subject: Re: Improve CRC32C performance on SSE4.2 In-Reply-To: <029f0848-8bc2-4d99-aebd-345949f97622@gmail.com> (Jesper Pedersen's message of "Sat, 14 Jun 2025 10:12:01 -0400") References: <87o6uqd3iv.fsf@163.com> <029f0848-8bc2-4d99-aebd-345949f97622@gmail.com> Date: Sun, 15 Jun 2025 01:31:43 +0000 Message-ID: <87frg1dc3k.fsf@163.com> MIME-Version: 1.0 Content-Type: text/plain X-CM-TRANSID: _____wA37C5_Ik5om8IVIQ--.908S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrZFyDKrWDJr17Aw47GFW5GFg_yoW3Wwb_Wa s8Zw4DWF45Xrsaq3Z8trZ3ArWvvrWIvr4Ikw4DXFyaqw18urs2qr9rX3s3KayxGFWIgrn2 kF929w4q9FZFkjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRis2-3UUUUU== X-Originating-IP: [113.250.190.7] X-CM-SenderInfo: x2klx3xlid0iqsrtqiywtou0bp/1tbioBltU2hOIHcCbwACsZ List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Jesper Pedersen writes: Hi, Thank you Nathan, Tomas and Jesper for the answers. The patch at [0] works for me and I could work with master smoothly now. > On 6/14/25 9:56 AM, Nathan Bossart wrote: >> I'm also genuinely curious why folks are using -O0... >> > > Personally, I use > > -O0 -fno-omit-frame-pointer > > for FlameGraph [1] investigations. Same here. I use clang as compiler because I use clangd for code indexing, gcc sometimes use different compiler options which may broke it. I used '-O0' in my daily coding and only use '-O2' when doing some performance testing. [0] https://www.postgresql.org/message-id/CANWCAZbsuavqUK4tg6UF-0-GVRMaq7BafUx4%2BDyd12y%3D-AuFAA%40mail.gmail.com -- Best Regards Andy Fan