Received: from localhost (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id F0CF66502C5 for ; Thu, 20 Nov 2008 11:21:25 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 93098-02-3 for ; Thu, 20 Nov 2008 11:21:19 -0400 (AST) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.174]) by mail.postgresql.org (Postfix) with ESMTP id CEB4F6502AA for ; Thu, 20 Nov 2008 11:21:17 -0400 (AST) Received: by ug-out-1314.google.com with SMTP id k40so300865ugc.7 for ; Thu, 20 Nov 2008 07:21:14 -0800 (PST) Received: by 10.67.115.14 with SMTP id s14mr3641559ugm.57.1227194474406; Thu, 20 Nov 2008 07:21:14 -0800 (PST) Received: from oxford.xeocode.com.enterprisedb.com ([82.16.16.210]) by mx.google.com with ESMTPS id 34sm748915ugh.10.2008.11.20.07.21.12 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 20 Nov 2008 07:21:13 -0800 (PST) To: Magnus Hagander Cc: PG Hackers Subject: Re: Error arguments in pl_exec.c In-Reply-To: <49257B22.6070005@hagander.net> (Magnus Hagander's message of "Thu\, 20 Nov 2008 15\:58\:42 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) X-Draft-From: ("nnimap+imap.gmail.com:HACKERS" 49179) References: <49257B22.6070005@hagander.net> From: Gregory Stark Organization: EnterpriseDB Date: Thu, 20 Nov 2008 15:21:08 +0000 Message-ID: <87hc62fmor.fsf@oxford.xeocode.com> MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200811/1354 X-Sequence-Number: 128066 Magnus Hagander writes: > I get the following warnings in HEAD > > pl_exec.c: In function =91exec_stmt_raise=92: > pl_exec.c:2538: warning: format not a string literal and no format argume= nts > pl_exec.c:2538: warning: format not a string literal and no format argume= nts > > > Attached patch seems right to me - objections? ick. that's actually a security hole. Thankfully it's new code in cvs head. --=20 Gregory Stark EnterpriseDB http://www.enterprisedb.com Ask me about EnterpriseDB's Slony Replication support!