Received: from malur.postgresql.org ([2a02:16a8:dc51::56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fXtmE-0001kO-GU
	for pgsql-hackers@arkaria.postgresql.org; Tue, 26 Jun 2018 19:37:23 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fXtmC-0004Jt-IB
	for pgsql-hackers@arkaria.postgresql.org; Tue, 26 Jun 2018 19:37:20 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <a.sher@postgrespro.ru>)
	id 1fXtmC-0004Jm-3b
	for pgsql-hackers@lists.postgresql.org; Tue, 26 Jun 2018 19:37:20 +0000
Received: from mail.postgrespro.ru ([93.174.131.138])
	by makus.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <a.sher@postgrespro.ru>)
	id 1fXtm8-0006bs-61
	for pgsql-hackers@postgresql.org; Tue, 26 Jun 2018 19:37:18 +0000
Received: from localhost (localhost [127.0.0.1])
	by mail.postgrespro.ru (Postfix) with ESMTP id 17AC721C1CCE;
	Tue, 26 Jun 2018 22:37:13 +0300 (MSK)
X-Virus-Scanned: Debian amavisd-new at postgrespro.ru
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=x tagged_above=-99 required=4 WHITELISTED tests=[]
	autolearn=unavailable
Received: from ars-thinkpad (nat03-43-2.netorn.net [188.35.130.88])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client did not present a certificate)
	by mail.postgrespro.ru (Postfix) with ESMTPSA id CD32721C1CB4;
	Tue, 26 Jun 2018 22:37:12 +0300 (MSK)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru;
	s=mail; t=1530041832;
	bh=P4NRmzaxsEoeVcvzdVGZFExODdGOB2TvLKNG8sAoImE=;
	h=References:From:To:Cc:Subject:In-reply-to:Date;
	b=DqjZ1VBFWiV+BnLArKkhNzURmD8PV2KjRUeL4s+2/4Lolbmdg/RWchW2got5eoMMI
	 qHqimyZX1+voXokr83HOVQk74so2bM4Q03W3a3XmaGFY2L2WhJkazl9L2ebUnSm3wK
	 yjGNs0mDBBDp0sYe7JzW27D8XnX4tEQIdxasSjpA=
References: <87k1qlve3d.fsf@ars-thinkpad>
 <20180626184238.qnyjzjuw33xzx6zn@alvherre.pgsql>
User-agent: mu4e 1.1.0; emacs 26.0.50
From: Arseny Sher <a.sher@postgrespro.ru>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Antonin Houska <ah@cybertec.at>,
 pgsql-hackers <pgsql-hackers@postgresql.org>,
 Andres Freund <andres@anarazel.de>, Petr Jelinek <petr@2ndquadrant.com>
Subject: Re: Fix slot's xmin advancement and subxact's lost snapshots in
 decoding.
In-reply-to: <20180626184238.qnyjzjuw33xzx6zn@alvherre.pgsql>
Date: Tue, 26 Jun 2018 22:37:11 +0300
Message-ID: <87in65uyoo.fsf@ars-thinkpad>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk


Alvaro Herrera <alvherre@2ndquadrant.com> writes:

> I'm struggling with this assert.  I find that test_decoding passes tests
> with this assertion in branch master, but fails in 9.4 - 10.  Maybe I'm
> running the tests wrong (no assertions in master?) but I don't see it.
> It *should* fail ...

Your v3 patch fails for me on freshest master (4d54543efa) in exactly
this assert, it looks like there is something wrong in your setup.

--
Arseny Sher
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company