Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f4usK-0001cn-1u for pgsql-hackers@arkaria.postgresql.org; Sat, 07 Apr 2018 20:55:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f4usI-0006P8-SK for pgsql-hackers@arkaria.postgresql.org; Sat, 07 Apr 2018 20:55:50 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f4upO-0000Iz-PS for pgsql-hackers@lists.postgresql.org; Sat, 07 Apr 2018 20:52:50 +0000 Received: from lungold.riddles.org.uk ([82.68.208.19]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f4upL-0005Vo-2p for pgsql-hackers@lists.postgresql.org; Sat, 07 Apr 2018 20:52:49 +0000 Received: from [192.168.127.1] (port=43055 helo=caithnard.riddles.org.uk) by lungold.riddles.org.uk with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.88 (FreeBSD)) (envelope-from ) id 1f4upE-0004Ho-EY; Sat, 07 Apr 2018 20:52:40 +0000 Received: from [127.0.0.1] (port=62058 helo=caithnard.riddles.org.uk) by caithnard.riddles.org.uk with esmtp (Exim 4.89 (FreeBSD)) (envelope-from ) id 1f4upD-000NdX-Hz; Sat, 07 Apr 2018 20:52:39 +0000 From: Andrew Gierth To: Teodor Sigaev Cc: Peter Geoghegan , Alexander Korotkov , Anastasia Lubennikova , PostgreSQL Hackers Subject: Re: WIP: Covering + unique indexes. In-Reply-To: <73780c3f-0fd6-bfb1-a56c-6aa83a3f7377@sigaev.ru> (Teodor Sigaev's message of "Sat, 7 Apr 2018 23:10:55 +0300") Message-ID: <87in92ix46.fsf@news-spur.riddles.org.uk> References: <56168952.4010101@postgrespro.ru> <95fb3cd8-648d-6362-302f-1b9bdc10e3e0@sigaev.ru> <73780c3f-0fd6-bfb1-a56c-6aa83a3f7377@sigaev.ru> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (berkeley-unix) Date: Sat, 07 Apr 2018 21:52:38 +0100 MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk >>>>> "Teodor" == Teodor Sigaev writes: >> I'll keep an eye on the buildfarm, since it's late in Russia. Teodor> Thank you very much! Now 23:10 MSK and I'll be able to follow Teodor> during approximately hour. Support for testing amcaninclude via pg_indexam_has_property(oid,'can_include') seems to be missing? Also the return values of pg_index_column_has_property for included columns seem a bit dubious... should probably be returning NULL for most properties except 'returnable'. I can look at fixing these for you if you like? -- Andrew (irc:RhodiumToad)