Feedback-ID: i1ff147bf:Fastmail
From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>,  David Geier <geidav.pg@gmail.com>,
  Peter Eisentraut <peter@eisentraut.org>,  pgsql-hackers
 <pgsql-hackers@postgresql.org>
Subject: Re: get rid of Pointer type, mostly
References: <4154950a-47ae-4223-bd01-1235cc50e933@eisentraut.org>
	<955002.1764000569@sss.pgh.pa.us>
	<CA+Tgmobo9ZMC0h1Z1Te9whf7q3LN7wUkzFLyuxfMZ4dyTNqKnw@mail.gmail.com>
	<957744.1764002037@sss.pgh.pa.us>
	<CA+TgmobhKe5WJybZ0EGQ85Qkxr-KLx4uW2_hFqt0iPbYq-af7Q@mail.gmail.com>
	<970261.1764008763@sss.pgh.pa.us>
	<646aa41b-9810-442e-9a5a-69a5604190d4@gmail.com>
	<CA+TgmobkziCEOmm+Pc7-fDxuoZY1fFvEPwFz-y5hUf-V-kzhtQ@mail.gmail.com>
	<985179.1764011713@sss.pgh.pa.us>
Date: Mon, 24 Nov 2025 20:08:46 +0000
In-Reply-To: <985179.1764011713@sss.pgh.pa.us> (Tom Lane's message of "Mon, 24
	Nov 2025 14:15:13 -0500")
Message-ID: <87jyzf6vn5.fsf@wibble.ilmari.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Archived-At: 
 <https://www.postgresql.org/message-id/87jyzf6vn5.fsf%40wibble.ilmari.org>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

Tom Lane <tgl@sss.pgh.pa.us> writes:

> Robert Haas <robertmhaas@gmail.com> writes:
>> On Mon, Nov 24, 2025 at 1:46 PM David Geier <geidav.pg@gmail.com> wrote:
>>> The GIN code makes use of pointer but src/backend/access/gin only has 29
>>> occurrences. If you like I can help out fixing up the GIN code and share
>>> a page here. Let me know.
>
>> I'd go for it! I mean, who knows whether your patch will be accepted?
>> But another pair of eyes couldn't hurt. It seems like we all agree
>> that a full removal of Pointer would be better than a partial removal;
>> it's just a question of whether we can get there without too much
>> other awkwardness.
>
> If there are actually places in GIN where using void* would be less
> readable than using Pointer, that would certainly be interesting
> information.  Perhaps the patch would need to spend some effort
> on adding comments, not just mechanically replacing the typedef?

I got curious and did the replacement, and IMO there's no need for any
further commentary than what's already there.  I did however take the
opportunity to get rid of some pointless casts (except the return value
of PG_GETARG_POINTER(), which seems to be de rigueur to redundantly
cast), and to convert a nearby char * that's only used for memcpy() to
void *.

- ilmari


--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
 filename=0001-Convert-remaning-uses-of-Pointer-to-void.patch