References: 
 <CAApHDvpb_63XQodmxKUF8vb9M7CxyUyT4sWvEgqeQU-GB7QFoQ@mail.gmail.com>
 <CAApHDvoV4QgNsXsegaCJQFHK4v8-gE7_DzXmSMgm_Hg+C+4oYg@mail.gmail.com>
 <CAMbWs49J2jv61DsQ_D=JgnuPMjbd1W3WoMw=-DB=zRpGYRh+yA@mail.gmail.com>
 <87o7cti48f.fsf@163.com>
 <CAApHDvoXPZ0K2HPwumz2B-ptfsbdyTb1esF3OO6-_JuKYWziAw@mail.gmail.com>
User-agent: mu4e 1.10.7; emacs 29.1
From: Andy Fan <zhihuifan1213@163.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Richard Guo <guofenglinux@gmail.com>, pgsql-hackers@lists.postgresql.org
Subject: Re: Properly pathify the union planner
Date: Sun, 18 Feb 2024 17:07:50 +0800
In-reply-to: 
 <CAApHDvoXPZ0K2HPwumz2B-ptfsbdyTb1esF3OO6-_JuKYWziAw@mail.gmail.com>
Message-ID: <87jzn2gmwh.fsf@163.com>
MIME-Version: 1.0
Content-Type: text/plain
Archived-At: <https://www.postgresql.org/message-id/87jzn2gmwh.fsf%40163.com>
Precedence: bulk


David Rowley <dgrowleyml@gmail.com> writes:

>>
>> The two if-clauses looks unnecessary, it should be handled by
>> pathkeys_count_contained_in already. The same issue exists in
>> pathkeys_useful_for_ordering as well. Attached patch fix it in master.
>
> I agree.  I'd rather not have those redundant checks in
> pathkeys_useful_for_setop(), and I do want those functions to be as
> similar as possible.  So I think adjusting it in master is a good
> idea.
>
> I've pushed your patch.
>
Thanks for the pushing!


-- 
Best Regards
Andy Fan