Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ojLiw-0003uc-KB
	for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Oct 2022 14:31:43 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ojLit-0007nQ-SK
	for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Oct 2022 14:31:39 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <ilmari@ilmari.org>)
	id 1ojLis-0007nH-77
	for pgsql-hackers@lists.postgresql.org; Fri, 14 Oct 2022 14:31:39 +0000
Received: from wout5-smtp.messagingengine.com ([64.147.123.21])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <ilmari@ilmari.org>)
	id 1ojLin-0005mo-8J
	for pgsql-hackers@lists.postgresql.org; Fri, 14 Oct 2022 14:31:37 +0000
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
	by mailout.west.internal (Postfix) with ESMTP id 62DAF32003C0
	for <pgsql-hackers@lists.postgresql.org>;
 Fri, 14 Oct 2022 10:31:29 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
  by compute2.internal (MEProxy); Fri, 14 Oct 2022 10:31:29 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilmari.org; h=cc
	:content-transfer-encoding:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm3; t=1665757888; x=
	1665844288; bh=hvXjzClkg5G+Wi7aG0JJIJbtWONrLMTn/S9nJKsVLWA=; b=l
	egcJncbkONUsM8SAqi+pjgag/rXiFpjkph8iuNvUg2IORWNGGTbWNu7L1hEpFUla
	jW9u57naswQoWZ+m8wAVtGDNG/yUa46sAGJcbaP7V+ZSLzMr74Nql/K0DdPjGZZI
	QGja7k0lul7SG5iJb/ga7stHMPHM++kW+VjE/Q1ev5O4aXODHHNRxFmM/rzD3RJd
	eAJGCGMw0k3Gms/NYI2O1zvEe8Lxdy93MKgJx/rS/Garn/PYKRgy5suh9S8YcBti
	A3tyNXppa+oPw3l10GVqj1Wx4xFY3aCAJx52I/PYDNrBGQ1dB/C9n5+W/PkJhb38
	06PwE6/mQJ2L3MRhZN8nQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-transfer-encoding:content-type
	:date:date:feedback-id:feedback-id:from:from:in-reply-to
	:in-reply-to:message-id:mime-version:references:reply-to:sender
	:subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender
	:x-me-sender:x-sasl-enc; s=fm3; t=1665757888; x=1665844288; bh=h
	vXjzClkg5G+Wi7aG0JJIJbtWONrLMTn/S9nJKsVLWA=; b=p5p3QuRdpVwPWgIeS
	8gQN78W51fxiLNrZYl0un8Rjdzo3yz701KMewm6KPOTMBf82Jw2T7OJJqr+J7rJL
	7irA/Sk0B24xPq8WmcQCHJv5+tyCTXOrglEFn7GWS1CZdm9I17/5n1dWlQQHJsWa
	f65vqN3n/NWPMIjJYGnSjk/C1vmFTm8D5nKnf18m6oxTvtGuFq59ROo9Mh3uwX3T
	3KB7pE8IomAxAa0rxVIWPE5SWJX687qbLKnCZX7JVtdJLHKpsMPmxPs0/KD4QueS
	YA5TL+FXoBUZHL82v3ZX0stVDCbNCq6c7xWmS8dkMzmSotrAzOdfHhwCv0eTWTMc
	Jmp4g==
X-ME-Sender: <xms:wHJJY73FGuABfB9C0p8_2fQYwdXucF4qrFw_fOdIZoryXsMwQ5bx-g>
    <xme:wHJJY6EbQPEDq6c_7hJEOOj0i46u_wQdBOIVA3oxWzjnwPgTSR4ejNB7SUACIfKz9
    fwr4bALETInoNUh72M>
X-ME-Received: 
 <xmr:wHJJY77B6l6IAhwr8ciNWbDBN4APAkeTGz5vBYG5LzAoVgh7eUsk_cRDZczYwJ5obWfd4seoDfa-ZpqQrQ>
X-ME-Proxy-Cause: 
 gggruggvucftvghtrhhoucdtuddrgedvfedrfeekvddgjeelucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhephffvufhfffgjkfgfgggtgfesthekredttderjeenucfhrhhomhepffgrghhf
    ihhnnhgpkfhlmhgrrhhipgforghnnhhsnohkvghruceoihhlmhgrrhhisehilhhmrghrih
    drohhrgheqnecuggftrfgrthhtvghrnhepfedvfeeigfdugfdthfffleduudevffejvdef
    keeuvdeiiedvjedtueejfeefudegnecuffhomhgrihhnpehpohhsthhgrhgvshhqlhdroh
    hrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehi
    lhhmrghrihesihhlmhgrrhhirdhorhhg
X-ME-Proxy: <xmx:wHJJYw2eEPh5HQqBlUD2v4DsLrWoX-us_Wo3GBujOTayID7j333jeg>
    <xmx:wHJJY-G9UsODyQJ88ttTnXMx5ZxBhYtpUqoWQN52usFnCMbZYsOJ9w>
    <xmx:wHJJYx-bJSthZUAmtKGcR002qmwrtrdzFsgz_uBIh2zIn3Sb3-Afjg>
    <xmx:wHJJY5zBdVcK9h9K747m-h9ZAyCQV7K04cif3fJH964UXMEVSn029A>
Feedback-ID: i1ff147bf:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA for
 <pgsql-hackers@lists.postgresql.org>; Fri,
 14 Oct 2022 10:31:28 -0400 (EDT)
From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Improve tab completion for ALTER TABLE on identity
 columns
References: <87mta1jfax.fsf@wibble.ilmari.org>
Date: Fri, 14 Oct 2022 15:31:26 +0100
In-Reply-To: <87mta1jfax.fsf@wibble.ilmari.org> ("Dagfinn Ilmari
 =?utf-8?Q?Manns=C3=A5ker=22's?=
	message of "Wed, 12 Oct 2022 15:18:46 +0100")
Message-ID: <87k052jx35.fsf@wibble.ilmari.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/87k052jx35.fsf%40wibble.ilmari.org>
Precedence: bulk

Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> writes:

> Hi Hackers,
>
> I noticed that psql has no tab completion around identity columns in
> ALTER TABLE, so here's some patches for that.

Added to the next commit fest:

https://commitfest.postgresql.org/40/3947/

- ilmari