Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wAmyf-000Kkf-1V for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Apr 2026 10:51:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wAmyd-005JCI-21 for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Apr 2026 10:51:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wAmyd-005JC0-0r for pgsql-hackers@lists.postgresql.org; Thu, 09 Apr 2026 10:51:12 +0000 Received: from fout-a1-smtp.messagingengine.com ([103.168.172.144]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wAmyb-00000000ANQ-2b2k for pgsql-hackers@lists.postgresql.org; Thu, 09 Apr 2026 10:51:11 +0000 Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfout.phl.internal (Postfix) with ESMTP id 62DB9EC0014 for ; Thu, 9 Apr 2026 06:51:07 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Thu, 09 Apr 2026 06:51:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilmari.org; h=cc :content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm1; t=1775731867; x=1775818267; bh=R49dY1kOWKucmF+HK3PS4ehyE9aUJ+5C 1uBYDH/5+gY=; b=NR5uV5P+EziO0xIriyKK9v2FbYM+bzTWT+g6P8axvormFtsB OzeXePecYq0scOfDtqAyFNq2/1ziI11zZk4AjAfCtEroxEDml1VDgmwVNu4K3psF sKarZ7W2AOFiEaVnP3cTqnMVEglDnnPlJh+q/4RN84H5Q6X/qmduaKM56xzt4yoJ NF0rhhVoaPRB5sNTY6MqsBDBb0bxmuOUbhguVYlZIcMyFy8q6eqSNVuD3jgILyOC 2xJ0FUjmfqvdu48IUivKaqfCsNdyYG4vnLhP985mYX6soV4nJv1IoG1An5AWfF1z ZqCVtD0RVASEQOaymiq/Ar1QQdQlT8eFgUdHog== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1775731867; x= 1775818267; bh=R49dY1kOWKucmF+HK3PS4ehyE9aUJ+5C1uBYDH/5+gY=; b=J 1wCjZeSr2rAaRtlM1Iia7rSEAdBLKZrFSJoKhW43b+GjwL0i8t8TQzvgYnJvD9Dq UtzwZQ7qNddWEk+NXTGrc1dNxadiHWsjHtg1t3aX2lkX93cqDxrUdhCjMlNn+smw 4sEwOdwf8Nept3fP+Yfy6G2PFljGg6ZPzLBhMfk7faFlZTaDyOzMw0mk1RhqAsVM a4lzbFHxH1sRpuz6MUkKG4EOxkA9KhM/H3qQBvx00ynyR22OqPzIheozzDIX7bzx +a6cbdUtgDMf7qo8My5iYpNFPZ9y2JuJ2ccJ4kA4TGtX+/EMItbYKhhtYeQwzL+L BUw3NqSGDPuepYItSFyaQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgddviedvlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgfgggtsehmtderredtreejne cuhfhrohhmpeffrghgfhhinhhnucfklhhmrghrihcuofgrnhhnshonkhgvrhcuoehilhhm rghrihesihhlmhgrrhhirdhorhhgqeenucggtffrrghtthgvrhhnpeeiieevtedvueevve ekfeeujeeikefgvddtteffkeegjeetvdejteehheeuleeivdenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehilhhmrghrihesihhlmhgrrhhird horhhgpdhnsggprhgtphhtthhopedupdhmohguvgepshhmthhpohhuthdprhgtphhtthho pehpghhsqhhlqdhhrggtkhgvrhhssehlihhsthhsrdhpohhsthhgrhgvshhqlhdrohhrgh X-ME-Proxy: Feedback-ID: i1ff147bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Thu, 9 Apr 2026 06:51:06 -0400 (EDT) From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= To: pgsql-hackers@lists.postgresql.org Subject: pgcrypto: remove useless px_memset() and BF_ASM Date: Thu, 09 Apr 2026 11:51:05 +0100 Message-ID: <87ldew2yqu.fsf@wibble.ilmari.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=-=-= Content-Type: text/plain Hi Hackers, In the thread about centralised architecture detection, I noticed that the BF_ASM macro in crypt-blowfish.c has never been defined to anything but 0, and the _BF_body_r() function it would call has never existed, so that can be got rid of. While investigating at that, I also noticed that px_memset(), which has the comment /* memset that must not be optimized away */, is only ever called with zero for the value, which could be better written with explicit_bzero() now that we have that. Attached are patches for both. - ilmari --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-pgcrypto-remove-unused-BF_ASM-macro.patch