Feedback-ID: i1ff147bf:Fastmail
From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Sami Imseih <samimseih@gmail.com>,  Tom Lane <tgl@sss.pgh.pa.us>,
  Maiquel Grassi <grassi@hotmail.com.br>,  Hunaid Sohail
 <hunaidpgml@gmail.com>,  "pgsql-hackers@postgresql.org"
 <pgsql-hackers@postgresql.org>,  "David G. Johnston"
 <david.g.johnston@gmail.com>,  Jim Jones <jim.jones@uni-muenster.de>,
  Nathan Bossart <nathandbossart@gmail.com>,  "Imseih (AWS), Sami"
 <simseih@amazon.com>,  Peter Eisentraut <peter@eisentraut.org>,  Pavel
 Luzanov <p.luzanov@postgrespro.ru>,  Erik Wienhold <ewie@ewie.name>,  Dean
 Rasheed <dean.a.rasheed@gmail.com>
Subject: Re: Psql meta-command conninfo+
References: <202502252118.5zgn3hmm37gf@alvherre.pgsql>
Date: Wed, 26 Feb 2025 12:34:28 +0000
In-Reply-To: <202502252118.5zgn3hmm37gf@alvherre.pgsql> (Alvaro Herrera's
	message of "Tue, 25 Feb 2025 22:18:47 +0100")
Message-ID: <87mse828bv.fsf@wibble.ilmari.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Archived-At: <https://www.postgresql.org/message-id/87mse828bv.fsf%40wibble.ilmari.org>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:

> On 2025-Feb-22, Alvaro Herrera wrote:
>
>> Also, there's a bunch of "(char *)" casts that are 100% due to
>> printTableAddCell() taking a char * instead of const char * for the cell
>> value.  That seems a bit silly, we should change that.
>
> Ah, but the problem is that most of the input cells there come from
> PQgetValue which returns a char *, so we'd need different casts
> elsewhere.  Nevermind this ...

Also, it calls mbvalidate(cell, ...), which can modify the contents
(stripping out invalid characters), so we'd better hope all the possible
PQsslAttribute() values are valid UTF-8 or we've got possible UB on our
hands.

- ilmari