Feedback-ID: i1ff147bf:Fastmail
From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
To: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,  Michael
 Paquier <michael@paquier.xyz>
Subject: Re: Replace (stat(<file>))[7] in TAP tests with -s
References: <b2020df7-d0fc-4ea5-b2a9-7efc6d36b2ac@gmail.com>
Date: Mon, 02 Oct 2023 12:44:59 +0100
In-Reply-To: <b2020df7-d0fc-4ea5-b2a9-7efc6d36b2ac@gmail.com> (Bertrand
	Drouvot's message of "Mon, 2 Oct 2023 11:35:45 +0200")
Message-ID: <87o7hhnt8k.fsf@wibble.ilmari.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Archived-At: 
 <https://www.postgresql.org/message-id/87o7hhnt8k.fsf%40wibble.ilmari.org>
Precedence: bulk

"Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com> writes:

> Hi hackers,
>
> Please find attached a tiny patch to $SUBJECT.
>
> It:
>
>  - provides more consistency to the way we get files size in TAP tests
>  - seems more elegant that relying on a hardcoded result position

I approve of removing use of the list form of stat, it's a horrible API.

If we weren't already using -s everywhere else, I would prefer
File::stat, which makes stat (in scalar context) return an object with
methods for the fields, so you'd do stat($file)->size.  It's included in
Perl core since 5.4, and we're already using it in several places for
other fields (mode and ino at least).

I see another use of stat array positions (for mtime) in
src/tools/msvc/Solution.pm, but that's on the chopping block, so not
much point in fixing.

- ilmari