public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dagfinn Ilmari Mannsåker <[email protected]>
To: Robert Haas <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: constants for tar header offsets
Date: Tue, 18 Apr 2023 17:56:43 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+Tgmob3wRzUhZbWDQ-6kgs84S+A7CJVsBWcD7+q+mKd3taZ3Q@mail.gmail.com>
References: <CA+TgmoZNbLwhmCrNtkJAvi8FLkwFdMeVU3myV2HQQpA5bvbRZg@mail.gmail.com>
	<[email protected]>
	<CA+TgmoZniAFyu-UOt-OtbGnVnc00BhGbN6sMjH_tX+XNoj1a_w@mail.gmail.com>
	<[email protected]>
	<CA+Tgmob3wRzUhZbWDQ-6kgs84S+A7CJVsBWcD7+q+mKd3taZ3Q@mail.gmail.com>

Robert Haas <[email protected]> writes:

> On Tue, Apr 18, 2023 at 12:06 PM Tom Lane <[email protected]> wrote:
>> Hmm, you're right: I checked the POSIX.1-2018 spec as well, and
>> it agrees that the prefix field is 155 bytes long.  Perhaps just
>> add another comment line indicating that 12 bytes remain unassigned?
>
> OK. Here's v2, with that change and a few others.

It still has magic numbers for the sizes of the fields, should those
also be named constants?

- ilmari

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: constants for tar header offsets
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox