From: ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=)
To: pgsql-hackers@lists.postgresql.org
Subject: Re: perlcritic: prohibit map and grep in void conext
References: <87fsvzhhc4.fsf@wibble.ilmari.org>
Date: Sun, 08 Aug 2021 00:15:47 +0100
In-Reply-To: <87fsvzhhc4.fsf@wibble.ilmari.org> ("Dagfinn Ilmari
 \=\?utf-8\?Q\?Manns\=C3\=A5ker\=22's\?\=
	message of "Tue, 27 Jul 2021 17:06:19 +0100")
Message-ID: <87o8a8g82k.fsf@wibble.ilmari.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/87o8a8g82k.fsf%40wibble.ilmari.org>
Precedence: bulk

ilmari@ilmari.org (Dagfinn Ilmari Mannsåker) writes:

> Hi hackers,
>
> In the patches for improving the MSVC build process, I noticed a use of
> `map` in void context.  This is considered bad form, and has a
> perlcritic policy forbidding it:
> https://metacpan.org/pod/Perl::Critic::Policy::BuiltinFunctions::ProhibitVoidMap.
>
> Attached is a patch that increases severity of that and the
> corresponding `grep` policy to 5 to enable it in our perlcritic policy,
> and fixes the one use that had already snuck in.

Added to the 2021-09 commitfest: https://commitfest.postgresql.org/34/3278/

- ilmari