From: ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=)
To: Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,  Michael Paquier <michael@paquier.xyz>,
  Magnus Hagander <magnus@hagander.net>,  Daniel Gustafsson <daniel@yesql.se>,
  PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] pg_upgrade: report the reason for failing to open the
 cluster version file
References: <87pne2w98h.fsf@wibble.ilmari.org>
	<44115C15-EE49-4BDE-A976-2901384B5E60@yesql.se>
	<87mu96w7c5.fsf@wibble.ilmari.org>
	<20200226014844.GF17153@paquier.xyz>
	<2760811A-9AF4-4725-8A8A-061940CCF962@yesql.se>
	<CABUevEygyP_o9LmEWbSGzP3Wu-sstGSrQE9kq_WpuOEy1FOm5g@mail.gmail.com>
	<20200226093551.GA106669@paquier.xyz> <9878.1582732525@sss.pgh.pa.us>
	<87k149w673.fsf@wibble.ilmari.org> <20200319192304.GA28431@momjian.us>
Date: Thu, 19 Mar 2020 19:40:35 +0000
In-Reply-To: <20200319192304.GA28431@momjian.us> (Bruce Momjian's message of
	"Thu, 19 Mar 2020 15:23:04 -0400")
Message-ID: <87o8ssuo98.fsf@wibble.ilmari.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Bruce Momjian <bruce@momjian.us> writes:

> On Wed, Feb 26, 2020 at 06:32:00PM +0000, Dagfinn Ilmari Mannsåker wrote:
>> Tom Lane <tgl@sss.pgh.pa.us> writes:
>> 
>> > Michael Paquier <michael@paquier.xyz> writes:
>> >> On Wed, Feb 26, 2020 at 10:06:38AM +0100, Magnus Hagander wrote:
>> >>> +1, seems like that would be a regression in value.
>> >
>> >> Having more generic messages is less work for translators, we have
>> >> PG_VERSION in the file name, and that's more complicated to translate
>> >> in both French and Japanese.  No idea about other languages.
>> >
>> > Just looking at the committed diff, it seems painfully obvious that these
>> > two messages were written by different people who weren't talking to each
>> > other.  Why aren't they more alike?  Given
>> >
>> >        pg_fatal("could not open version file \"%s\": %m\n", ver_filename);
>> >
>> > (which seems fine to me), I think the second ought to be
>> >
>> >        pg_fatal("could not parse version file \"%s\"\n", ver_filename);
>> 
>> Good point.  Patch attached.
>
> Patch applied, and other adjustments:

Thanks!

- ilmari
-- 
- Twitter seems more influential [than blogs] in the 'gets reported in
  the mainstream press' sense at least.               - Matt McLeod
- That'd be because the content of a tweet is easier to condense down
  to a mainstream media article.                      - Calle Dybedahl