Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uZISq-001OTB-NM for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Jul 2025 00:15:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uZISn-00CUMY-Uy for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Jul 2025 00:15:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uZISn-00CULv-Kz for pgsql-hackers@lists.postgresql.org; Wed, 09 Jul 2025 00:15:06 +0000 Received: from m16.mail.163.com ([220.197.31.3]) by magus.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1uZISh-006Y5w-0a for pgsql-hackers@postgresql.org; Wed, 09 Jul 2025 00:15:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version: Content-Type; bh=uLRgXrvRc+DyL42Cbkoo16YPMXnhGwXEWlffnmMoGto=; b=aLAyAysVRz8x5Pz6UQsXF4zKVR4HXWFgbmhdXnhlAK7gaRveFiXRD8vJEMXmaP H7WmXmUQxqn0sZ1VWolo6GZ3zLq7ixb/U21L4B5A/O7190eYvCn3Pxmqbw4yyzCY VqL3mmMOagn1+BE+w4a5n7BIBW7rtshcXv4nIby7v6SEc= Received: from lovely-coding (unknown []) by gzga-smtp-mtada-g0-0 (Coremail) with SMTP id _____wBHhwButG1oB9C9DQ--.64606S3; Wed, 09 Jul 2025 08:14:39 +0800 (CST) From: Andy Fan To: Fujii Masao Cc: Tom Lane , "Hayato Kuroda (Fujitsu)" , 'Michael Paquier' , PostgreSQL Hackers Subject: Re: A assert failure when initdb with track_commit_timestamp=on In-Reply-To: <7547e524-bf5f-45ef-bcbc-59bc55dae8be@oss.nttdata.com> (Fujii Masao's message of "Tue, 8 Jul 2025 17:08:08 +0900") References: <87plejmnpy.fsf@163.com> <1f8f703d-72e8-4d05-ab16-ff0403a1d19d@oss.nttdata.com> <87o6u19z9w.fsf@163.com> <3694f39a-7148-4197-91fe-25f3d01222b7@oss.nttdata.com> <249358.1751643017@sss.pgh.pa.us> <262595.1751649473@sss.pgh.pa.us> <75d59502-b571-4df8-9269-fd07cee52dd4@oss.nttdata.com> <9093.1751736193@sss.pgh.pa.us> <61810.1751738407@sss.pgh.pa.us> <7547e524-bf5f-45ef-bcbc-59bc55dae8be@oss.nttdata.com> Date: Wed, 09 Jul 2025 08:14:38 +0800 Message-ID: <87plea9q4x.fsf@163.com> MIME-Version: 1.0 Content-Type: text/plain X-CM-TRANSID: _____wBHhwButG1oB9C9DQ--.64606S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7XF4xCrWkCr15KFyDJw4fXwb_yoW3WrX_Wa 1jqrWvkryDGFyIvws8Aw1agrWku39rGFn8Grn3GF42yrZrJF4S9ryDZ34UCrnxu3ySgr98 CrZrXaySk3ya9jkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjrWFUUUUUU== X-Originating-IP: [101.227.46.168] X-CM-SenderInfo: x2klx3xlid0iqsrtqiywtou0bp/xtbBzxaEU2htn8bubgABsT List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Fujii Masao writes: > Shouldn't we also add a TAP test to verify that initdb works correctly > with GUCs marked as GUC_NOT_IN_BOOTSTRAP? After revert 5a6c39b6d, the test case could be as simply as below: I also tested this change. Just FYI. modified src/test/modules/commit_ts/t/001_base.pl @@ -11,8 +11,7 @@ use Test::More; use PostgreSQL::Test::Cluster; my $node = PostgreSQL::Test::Cluster->new('foxtrot'); -$node->init; -$node->append_conf('postgresql.conf', 'track_commit_timestamp = on'); +$node->init(extra => ['-c', 'track_commit_timestamp=on', "-c", "transaction_timeout=10s" ]); $node->start; # Create a table, compare "now()" to the commit TS of its xmin -- Best Regards Andy Fan