From: Andy Fan <zhihuifan1213@163.com>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Comment in portal.h
In-Reply-To: 
 <CAPmGK14HVYBZYZtHabjeCd-e31VT=wx6rQNq8QfehywLcpZ2Hw@mail.gmail.com>
	(Etsuro Fujita's message of "Tue, 30 Jul 2024 19:39:27 +0900")
References: 
 <CAPmGK14HVYBZYZtHabjeCd-e31VT=wx6rQNq8QfehywLcpZ2Hw@mail.gmail.com>
Date: Wed, 31 Jul 2024 07:55:39 +0800
Message-ID: <87plqusadg.fsf@163.com>
MIME-Version: 1.0
Content-Type: text/plain
Archived-At: <https://www.postgresql.org/message-id/87plqusadg.fsf%40163.com>
Precedence: bulk

Etsuro Fujita <etsuro.fujita@gmail.com> writes:

> Hi,
>
> I noticed $SUBJECT while working on something else:
>
>     /*
>      * Where we store tuples for a held cursor or a PORTAL_ONE_RETURNING or
>      * PORTAL_UTIL_SELECT query.  (A cursor held past the end of its
>      * transaction no longer has any active executor state.)
>      */
>     Tuplestorestate *holdStore; /* store for holdable cursors */
>     MemoryContext holdContext;  /* memory containing holdStore */
>
> We do that for PORTAL_ONE_MOD_WITH as well, so the comment should be
> "Where we store tuples for a held cursor or a PORTAL_ONE_RETURNING,
> PORTAL_ONE_MOD_WITH, or PORTAL_UTIL_SELECT query.".  Attached is a
> patch for that.

Patch looks good to me.

All the codes of PortalRun & FillPortalStore & PortalRunSelect are
consistent with this idea. 

-- 
Best Regards
Andy Fan