public inbox for [email protected]  

help / color / mirror / Atom feed
From: Andy Fan <[email protected]>
To: Andy Fan <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: Julien Rouhaud <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: using extended statistics to improve join estimates
Date: Sun, 28 Apr 2024 09:43:42 +0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<20220119101809.wzrjvh4jsnoakgny@jrouhaud>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>


Hello Tomas!

>>> At for the code level, I reviewed them in the top-down manner and almost
>>> 40% completed. Here are some findings just FYI. For efficiency purpose,
>>> I provide each feedback with a individual commit, after all I want to
>>> make sure my comment is practical and coding and testing is a good way
>>> to archive that. I tried to make each of them as small as possible so
>>> that you can reject or accept them convinently.
>>> 
>>> 0001 is your patch, I just rebase them against the current master. 0006
>>> is not much relevant with current patch, and I think it can be committed
>>> individually if you are OK with that.
>>> 
>>> Hope this kind of review is helpful.
>>> 
>>
>> Cool! There's obviously no chance to get this into v18, and I have stuff
>> to do in this CF. But I'll take a look after that.
>
> Good to know that. I will continue my work before that. 

I have completed my code level review and modification. These individual
commits and message probably be helpful for discussion. 

-- 
Best Regards
Andy Fan



Attachments:

  [application/x-tar] ext_stats_on_join.tar (170.0K, ../[email protected]/2-ext_stats_on_join.tar)
  download

view thread (8+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: using extended statistics to improve join estimates
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox