Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j2b7D-0007Zn-JT for pgsql-bugs@arkaria.postgresql.org; Fri, 14 Feb 2020 13:34:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j2b79-0007vM-QE for pgsql-bugs@arkaria.postgresql.org; Fri, 14 Feb 2020 13:34:39 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j2b79-0007vD-74 for pgsql-bugs@lists.postgresql.org; Fri, 14 Feb 2020 13:34:39 +0000 Received: from cyclops.postgrespro.ru ([93.174.131.138] helo=mail.postgrespro.ru) by makus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1j2b71-000603-DU for pgsql-bugs@lists.postgresql.org; Fri, 14 Feb 2020 13:34:37 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id 56B3221C622A; Fri, 14 Feb 2020 16:34:29 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=x tagged_above=-99 required=4 WHITELISTED tests=[] autolearn=unavailable Received: from ars-thinkpad (unknown [192.168.28.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id 21AD421C1F8E; Fri, 14 Feb 2020 16:34:29 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1581687269; bh=bQiUts6g9lZ2w29Cw22ZTckSkOfffQm0PVsXKxtHDoc=; h=References:From:To:Cc:Subject:In-reply-to:Date; b=GLAi5cQ7a6MOdJ4fkvvYr5mzLByT/qby8R4UUEWl3lZ1/+giO6NBC3F2yhDsCzkgv WNMqHpH0rCsQoMa63IZUpAsxstCL59ICaGyQ/+sXlD3QOvcs78rqkswbwS2Blrx0/e IutQlOi3f3w6Bv+u7W3BxT9NXzjfXGrnFFB/Bnc4= References: <20191024213157.7pm6niybfxgpvmgg@alap3.anarazel.de> <87eez1fh48.fsf@ars-thinkpad> <8736bs81sx.fsf@ars-thinkpad> <871rrb942q.fsf@ars-thinkpad> <87zhdx76d5.fsf@ars-thinkpad> <8736bjoiax.fsf@ars-thinkpad> <87wo8ulhjl.fsf@ars-thinkpad> <87lfp9u4kp.fsf@ars-thinkpad> <87tv3x72hh.fsf@ars-thinkpad> User-agent: mu4e 1.2.0; emacs 26.0.50 From: Arseny Sher To: Amit Kapila Cc: Dilip Kumar , Andres Freund , "Hsu\, John" , "pgsql-bugs\@lists.postgresql.org" Subject: Re: ERROR: subtransaction logged without previous top-level txn record In-reply-to: Date: Fri, 14 Feb 2020 16:34:28 +0300 Message-ID: <87pneh70nv.fsf@ars-thinkpad> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Amit Kapila writes: > Attached is a patch where I have modified the comments and slightly > edited the commit message. This patch was not getting applied in v11 > and branches lower than that, so I prepared a patch for those branches > as well. I have tested this patch till 9.5 and it works as intended. > > Can you also once check the patch and verify it in back-branches? Sorry for the delay. I'm fine with changes. make check down to 9.5 is also happy here. Interesting thing about wal_log_hints, hasn't occured to me. -- cheers, arseny