Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sxshv-00CyPH-Nf for pgsql-hackers@arkaria.postgresql.org; Mon, 07 Oct 2024 18:43:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sxsgu-00EgkV-8o for pgsql-hackers@arkaria.postgresql.org; Mon, 07 Oct 2024 18:42:44 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sxsgs-00EgkL-Gy for pgsql-hackers@lists.postgresql.org; Mon, 07 Oct 2024 18:42:43 +0000 Received: from fout-a8-smtp.messagingengine.com ([103.168.172.151]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sxsgl-002zsk-Cq for pgsql-hackers@lists.postgresql.org; Mon, 07 Oct 2024 18:42:41 +0000 Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfout.phl.internal (Postfix) with ESMTP id 1848313801DF; Mon, 7 Oct 2024 14:42:34 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-12.internal (MEProxy); Mon, 07 Oct 2024 14:42:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilmari.org; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1728326554; x=1728412954; bh=DGBGowmCg7 6OWNGJkM9D3nos0WoUjvIGR35Qk4Cv6Qc=; b=hgO2N1OYkwkavKWTojxzEt5Cws YLXoo9TMJmkl/xPZ4uF2VxbddusC/eCZV9R4rBQOh+0+bm3Ki7GuCLG08jQPE1Ts oD7qTPqpIVFW7BlWWK7P7Sz7mP7639LYHGlZDGOshuUq4VISRKNUi1XJOOk0ewFa Pdkmx2LLr7DTukt9eHG3YQxA+TRNIwFp2A3tBKn5uHoqAavnz7T78nZQnXh2K5KB W05pM8Sof1R8riP5DKLDurMghw/PkcCUzYoft1klsDF7x2GvZBFuHBhHXXohioXN uDVZ4wsaH850ed7mobs+xwG9I+lTO4hfP4z3X/9ErALzAv530XiVqVbALiHQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1728326554; x=1728412954; bh=DGBGowmCg76OWNGJkM9D3nos0WoU jvIGR35Qk4Cv6Qc=; b=edOHFctl3PnBgcKmhS35wXzLTR0t+d9wkd3Yyoqxz9RY EndpyeGsKMlN6/bSX0pCNDr7HNYVdssUCD149IQCdRNlRww+jwzEb+e0C41QusI6 hQTgOsrjJgNyV9jQbEcrF5WfKZwFDBjZ4x5xAeizrQtOgIAgB3BDMDrjF0L54ySW GuDK13P/QVpyVL6YV5GZ6ttt2iRb/gQw2/35KljxhPBMITnU7bWMxFrddc/coIaw n66fd5aJ7dRuciLn0FqsnLm/XPmkhwZkfmySwODyCy5Q1YCOfjPvowcV1nyXRh/e AoeQhsif6qeEsJVEKPRHQMNpiJAiVWNkXd+hWpSdXw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvddvledgudeftdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufhfffgjkfgfgggtsehttdertddtreej necuhfhrohhmpeffrghgfhhinhhnucfklhhmrghrihcuofgrnhhnshonkhgvrhcuoehilh hmrghrihesihhlmhgrrhhirdhorhhgqeenucggtffrrghtthgvrhhnpeekleejueefhfff kefhkedtfeeluedvieeihfehfeeffeeggeduffduheejjeeigfenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehilhhmrghrihesihhlmhgrrhhi rdhorhhgpdhnsggprhgtphhtthhopeegpdhmohguvgepshhmthhpohhuthdprhgtphhtth hopehpghhsqhhlqdhhrggtkhgvrhhssehlihhsthhsrdhpohhsthhgrhgvshhqlhdrohhr ghdprhgtphhtthhopehmsggrnhgtkhesghhmgidrnhgvthdprhgtphhtthhopegurghnih gvlheshigvshhqlhdrshgvpdhrtghpthhtohepthhomhgrshesvhhonhgurhgrrdhmvg X-ME-Proxy: Feedback-ID: i1ff147bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Oct 2024 14:42:32 -0400 (EDT) From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= To: Tomas Vondra Cc: Daniel Gustafsson , Michael Banck , PostgreSQL Hackers Subject: Re: Changing the state of data checksums in a running cluster References: <801a7cc1-bc23-4253-9b98-a5700f30e98e@enterprisedb.com> <383DA36E-405C-430E-A677-DB045EA37142@yesql.se> <66fb29a6.050a0220.1c8f2f.8be8@mx.google.com> <8B317721-1CB7-4F82-B4DA-6B15AB1725D1@yesql.se> <642b8eeb-06ef-4aed-97a8-5297d9f67142@vondra.me> Date: Mon, 07 Oct 2024 19:42:31 +0100 In-Reply-To: <642b8eeb-06ef-4aed-97a8-5297d9f67142@vondra.me> (Tomas Vondra's message of "Mon, 7 Oct 2024 16:46:25 +0200") Message-ID: <87r08rah60.fsf@wibble.ilmari.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Tomas Vondra writes: > 3) unnecessary ListCell in DataChecksumsWorkerMain() on line 1345, > shadowing earlier variable All the ListCell variables can be eliminated by using the foreach_ptr and foreach_oid macros instead of plain foreach. - ilmari