From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>,
 Alvaro Herrera <alvherre@2ndquadrant.com>,
 David Rowley <david.rowley@2ndquadrant.com>,
 Thomas Munro <thomas.munro@enterprisedb.com>
Subject: Re: Using POPCNT and other advanced bit manipulation instructions
In-Reply-To: <2F6CDF3B-08B9-4A15-ABDF-55D7F82AB76E@anarazel.de> (Andres
	Freund's message of "Wed, 13 Feb 2019 20:44:49 +0100")
Message-ID: <87r2cbo4c3.fsf@news-spur.riddles.org.uk>
References: <20190213191829.GA19406@alvherre.pgsql>
	<7193.1550086814@sss.pgh.pa.us>
	<2F6CDF3B-08B9-4A15-ABDF-55D7F82AB76E@anarazel.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (berkeley-unix)
Date: Wed, 13 Feb 2019 20:09:01 +0000
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

>>>>> "Andres" == Andres Freund <andres@anarazel.de> writes:

 >> It's likely to be hard to tell, given the amount of pink from the
 >> Ryu patch. If Andrew is not planning to clean that up PDQ,

Besides crake (x-version), fulmar (icc) and lorikeet (cygwin), I hope
the rest of the known failures should pass on the next cycle; the
mac/ppc failures are because we redefine "bool" in a way that broke the
upstream code's c99 assumptions, and the rest are numerical instability
in ts_rank.

 >> I'd suggest reverting that patch pending having some repairs for it.

 Andres> I'd assume that breaking bit counting would cause distinct
 Andres> enough damage (compile time or crashes). That's not to say that
 Andres> reverting ryu shouldn't be considered (although I'm not that
 Andres> bothered by cross version, ia64 and cygwin failures, especially
 Andres> because the latter two might be hard to come by outside the
 Andres> bf).

IA64 is working fine as far as I can see (specifically, anole is
passing); it's ICC on x86_64 that broke (fulmar).

-- 
Andrew (irc:RhodiumToad)