Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wWurv-002wNX-30 for pgsql-hackers@arkaria.postgresql.org; Tue, 09 Jun 2026 11:43:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wWuru-0079lI-2c for pgsql-hackers@arkaria.postgresql.org; Tue, 09 Jun 2026 11:43:42 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wWuru-0079l4-1e for pgsql-hackers@lists.postgresql.org; Tue, 09 Jun 2026 11:43:42 +0000 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wWurs-00000001qSk-2Nk1 for pgsql-hackers@lists.postgresql.org; Tue, 09 Jun 2026 11:43:41 +0000 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-bebde89cfd3so689474366b.2 for ; Tue, 09 Jun 2026 04:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781005418; x=1781610218; darn=lists.postgresql.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=6igq9lCvMsiIC0J2DOehTVG2znw19KdtJLeDmZaOs+0=; b=UmgXcRDtDvVkg/S8tjOgbEt/ZzjilzUgAvSIjQVP5J6qhJcbiHc2mlA4CVuizGEwvf xWprzSDxXnm/aybD1l8YH2no9wWRYdwTSMPM9m2BSuodN3DeA2+B2kAwpLTNMbuNcD4z c7xlM0Ehl6iqFtuu22GCl7NHeIKD3HQGdPDM3IXteO0+7CS6ZIY8xVKIYrtdnBa5NuMs UdiiaR1EKUgFH9s8VleexypFBYU1lXq9bYvmY2SF74d/Ee1RfLucOWUhKHlVk6zb0g5K x0LWDn/lf0nsIpGpI49EFnzv5efG9RE0G77f6s8vFi3aC9EoIkA6DZcCRfPxiu1pm17w sc5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781005418; x=1781610218; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=6igq9lCvMsiIC0J2DOehTVG2znw19KdtJLeDmZaOs+0=; b=Nhczk4/5TcvdNis8RRlJxqVX9Dtp/zSdbmrsX7tz3Oy/Eg6u7XBjOHO0EgF8i4aEor n7SkWhaN/0Te4UYx3XhDE9LJIifXw4R4Hq/TXtfnAkZha5/lQe2LVw4F5rIM67YL6G7N qx/sRRYAiElIqtAkliOEPVMU7vDElzMctp5JAKLBjrJKNRd+fCiv+FzGiN518UfsiuIY 5LO62O6Jk6452POu0Uik4hZZ+bkpujypqgqCXrBzYOpG/Jw1ki8UEUA4m/A4ia+KNW/E hJGZ+qzUjqSUOH6bRyugsCwtOZjgLHbqvUoVqmc7C+Ju/OFisFx+7AS0IZLc+qYpoYVM hyAA== X-Forwarded-Encrypted: i=1; AFNElJ9qSvzBf4tJpI2Jf0/I+4sNy1QIcltyTMqhEu17kuV0JaKFszyy3lw0Sz+MHYxHVDvIiqu0P3P7u3TPln0B@lists.postgresql.org X-Gm-Message-State: AOJu0YyL67YVjGCDrgA0737I43GYnyHVnJ6oZsTbFFZCLPqiZXVDpNRH FyLNF/pcPD3l1v3XRsgqr3IKaZP2ygIT2g7tpIWgGaEZVpoT1M0v260= X-Gm-Gg: Acq92OFVSDTpYtM3ehUY2IJYHiv79QjlEoG0vJLgPynoojXOFz3WAwOs+VDXwEpwILo mWXdD/280Me2HQWs2/LkkPPVh/9/DyxGZ8qeAvwwtvWcJKdGkQK7I5y4/bxrSpF0prmz/zC5BQZ UCCI8rehQn4Xy2OW+6oEuefnIlWtUtbLMwWOhf7YnGpsY6JRmODt6KbUU1VblKftdVY8f0NAXVA 1TfYVrKAw8sMKhjK1lm/3Gu/QV5QsNi3RmrEMiNY+VIr5n6+UMOfn3eLreUV5WUVySVNzCjbs2T baX+217RjM03G+6LUm4YSE6eqg3FwAf1LYd1YixunCtc9xlzmp6CXILPz02TKe4fIsgUOx7aY/a +gN89nKOwiWsL+XC8RywPW0yxlE4DzDmMiZQgtalC8ieVBmP9uJY24q5fYbEpDFNoGOphANWAGp 0D4aXOEoLaUjX1QIEjbgCZjxk7R/yFARanXkW9F24Bk/xX678UXA== X-Received: by 2002:a17:907:6c0f:b0:bda:5265:423 with SMTP id a640c23a62f3a-bf373306302mr961686966b.44.1781005418225; Tue, 09 Jun 2026 04:43:38 -0700 (PDT) Received: from localhost ([2a00:6d43:908:5803::3]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf05176fd14sm1033846166b.11.2026.06.09.04.43.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 04:43:37 -0700 (PDT) From: "Jonathan Gonzalez V." To: Japin Li Cc: Peter Smith , pgsql-hackers@lists.postgresql.org Subject: Re: Add pg_get_publication_ddl function In-Reply-To: (Japin Li's message of "Wed, 20 May 2026 18:00:56 +0800") References: <70d20c14d1c14f93e4200c1a9327b97d7c18a782.camel@gmail.com> Date: Tue, 09 Jun 2026 13:43:35 +0200 Message-ID: <87se6w3pnc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Japin Li writes: Hi! > > + buf = makeStringInfo(); > > I have one more comment: where possible, we should use stack-allocated > StringInfoData objects, as was done in commits a63bbc811d4 and 6d0eba66275. Makes sense! Will do the changes for the v3 Thank you! -- Jonathan Gonzalez V. EDB https://www.enterprisedb.com