Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ramwX-00BSX3-99
	for pgsql-hackers@arkaria.postgresql.org; Fri, 16 Feb 2024 01:23:09 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ramwT-00GZbw-Be
	for pgsql-hackers@arkaria.postgresql.org; Fri, 16 Feb 2024 01:23:05 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <zhihuifan1213@163.com>)
	id 1ramwS-00GZbo-Lk
	for pgsql-hackers@lists.postgresql.org; Fri, 16 Feb 2024 01:23:05 +0000
Received: from m16.mail.163.com ([117.135.210.3])
	by magus.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <zhihuifan1213@163.com>)
	id 1ramwM-007QA7-3D
	for pgsql-hackers@lists.postgresql.org; Fri, 16 Feb 2024 01:23:02 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;
	s=s110527; h=From:Subject:Date:Message-ID:MIME-Version:
	Content-Type; bh=yrnpBkmTj6qk6XXug7xrzmypN64B74V4QX32bQSljkY=;
	b=G8mgWj9sVe6dPiC9Ype0fMbqh60wJr02EGqGVAoF4FDKphn848blDv/X0HhEUQ
	KR/vQk9bwL5V9BS+2y2RPk03V39QhQ83bKIrjXmvHzEhUGCCKBdWcHzi1QKLyM9S
	Py0wv9ttQYkRSLGSMyMtKReyqGsfPZdF/FFV4GHrW7Ivg=
Received: from 8235eee8a2a0 (unknown [140.205.118.227])
	by gzga-smtp-mta-g1-0 (Coremail) with SMTP id _____wCXCWXnuM5lBxXrCQ--.17865S3;
	Fri, 16 Feb 2024 09:22:48 +0800 (CST)
References: <CAKU4AWrXSkUV=Pt-gRxQT7EbfUeNssprGyNsB=5mJibFZ6S3ww@mail.gmail.com>
 <CAApHDvry0nSV62kAOH3iccvfPhGPLN0Q97+=b1RsDPXDz3=CiQ@mail.gmail.com>
 <CAKU4AWoksFSs_6K5ZCzz68Oq+3uZb5g6sb8-dXJ6cChgYQm-yw@mail.gmail.com>
 <CAApHDvoMGyc+1eb8g5rEMUUMeGWhe2c_f8yvJjUO1kUHZj0h7w@mail.gmail.com>
 <CAKU4AWp9aTafjWwCqOauC7jmbuX+tGEWkRrBwXYhW-CFQXmRig@mail.gmail.com>
 <CAKU4AWqaTNPrYcb_cMEDDYWZVGfFxuUjr75F5LBZwnUQ0JvVPw@mail.gmail.com>
 <CAApHDvqf+YNFr_GbU4aJ5G7ZGJoZJ-R6CcFNaVi3QRpcgnNyAA@mail.gmail.com>
 <CAKU4AWqC5dR6DJ+XYiE+W4YiaokbE-myVgdnvqX3wx_Z87hk+w@mail.gmail.com>
 <CAApHDvrgSM5mdix-2YLYMJVaz+-vEq5mBPQ4jbDJYpy3=rc7dQ@mail.gmail.com>
 <CAKU4AWo0F3vMZp0WMuN9-WtZpA0CCmd+gKqdaix_TqgXYkSwWg@mail.gmail.com>
 <CAApHDvrf54zt5Y52nQp99nOYcXQU92=s2_9szwH8A17wCJBg=w@mail.gmail.com>
 <CA+hUKGLqC-NobKYfjxNM3Gexv9OJ-Fhvy9bugUcXsZjTqH7W=Q@mail.gmail.com>
 <87eddeiffk.fsf@163.com> <87a5o2i0ev.fsf@163.com>
 <CAApHDvogv5MBw6JV82Yb6gAa0mp64HQtX--TSK_wZOn9x2fP4Q@mail.gmail.com>
User-agent: mu4e 1.10.7; emacs 29.1
From: Andy Fan <zhihuifan1213@163.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>, Andy Fan
 <zhihui.fan1213@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>,
 Zhang Mingli <zmlpostgres@gmail.com>, pgsql-hackers@lists.postgresql.org
Subject: Re: make add_paths_to_append_rel aware of startup cost
Date: Fri, 16 Feb 2024 09:19:05 +0800
In-reply-to: <CAApHDvogv5MBw6JV82Yb6gAa0mp64HQtX--TSK_wZOn9x2fP4Q@mail.gmail.com>
Message-ID: <87sf1tgq3c.fsf@163.com>
MIME-Version: 1.0
Content-Type: text/plain
X-CM-TRANSID:_____wCXCWXnuM5lBxXrCQ--.17865S3
X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73
	VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUYYL9DUUUU
X-Originating-IP: [140.205.118.227]
X-CM-SenderInfo: x2klx3xlid0iqsrtqiywtou0bp/xtbBzwqGU2V4H0gdxQAAsC
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/87sf1tgq3c.fsf%40163.com>
Precedence: bulk


David Rowley <dgrowleyml@gmail.com> writes:

> I'd be more happy using this one as percentage-wise, the cost
> difference is much larger.

+1 for the percentage-wise.
>
> I checked that the t2.thounsand = 0 query still tests the cheap
> startup paths in add_paths_to_append_rel().

I get the same conclusion here. 
>
> So, if nobody has any better ideas, I'm just going to push the " and
> t2.thousand = 0" adjustment.

LGTM.

-- 
Best Regards
Andy Fan