Feedback-ID: i1ff147bf:Fastmail
From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Brar Piening <brar@gmx.de>,  Alvaro Herrera <alvherre@alvh.no-ip.org>,
  "Karl O. Pinc" <kop@karlpinc.com>,  Tom Lane <tgl@sss.pgh.pa.us>,
  vignesh C <vignesh21@gmail.com>,  Ian Lawrence Barwick
 <barwick@gmail.com>,  pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: doc: add missing "id" attributes to extension packaging page
References: <20230323093555.3icw7zetwtmtrrzu@alvherre.pgsql>
	<a41ed60d-2f95-da52-ba8b-b0b1cc37f3a4@gmx.de>
	<184dc41b-7407-1bb9-7fd4-7fb35db8b993@enterprisedb.com>
	<c6690867-4b06-ad16-b784-4824fcd4d43a@gmx.de>
	<cea67271-ef9f-6c94-e303-bf9269ef6f35@enterprisedb.com>
	<91edf03b-7b63-67b6-7f44-bfeb48e97056@gmx.de>
	<8c745b14-9443-274d-5900-db3f276ee293@enterprisedb.com>
Date: Thu, 13 Apr 2023 15:58:03 +0100
In-Reply-To: <8c745b14-9443-274d-5900-db3f276ee293@enterprisedb.com> (Peter
	Eisentraut's message of "Thu, 13 Apr 2023 10:31:43 +0200")
Message-ID: <87sfd3rfr8.fsf@wibble.ilmari.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Archived-At: <https://www.postgresql.org/message-id/87sfd3rfr8.fsf%40wibble.ilmari.org>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:

> On 06.04.23 16:19, Brar Piening wrote:
>> 001-make_html_ids_discoverable_v5.postgresql.patch which needs to be
>> applied to the postgresql repository. It adds the XSLT to generate the
>> id links and the CSS to hide/display them. I've added comments as
>> suggested above.
>> 002-add-discoverable-id-style_v1.pgweb.patch which needs to be applied
>> to the pgweb repository. It adds the CSS to the offical documentation site.
>
> The first patch has been committed.
>
> The second patch should be sent to pgsql-www for integrating into the
> web site.
>
> Side project: I noticed that these new hover links don't appear in the
> single-page HTML output (make postgres.html), even though the generated 
> HTML source code looks correct.  Maybe someone has an idea there.

Another side note: I notice the links don't appear on <refsectN> elements
(e.g. https://www.postgresql.org/docs/devel/sql-select.html#SQL-WITH),
only <sectN>.

- ilmari