From: Andrei Zubkov <zubkov@moonset.ru>
To: Alena Rybakina <lena.ribackina@yandex.ru>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>,  Andrei Lepikhov
 <lepihov@gmail.com>,  pgsql-hackers <pgsql-hackers@postgresql.org>,
  Alexander Korotkov <aekorotkov@gmail.com>,  Amit Kapila
 <amit.kapila16@gmail.com>,  Jim Nasby <jnasby@upgrade.com>,  Bertrand
 Drouvot <bertranddrouvot.pg@gmail.com>,  Kirill Reshke
 <reshkekirill@gmail.com>,  Masahiko Sawada <sawada.mshk@gmail.com>,
  Melanie Plageman <melanieplageman@gmail.com>,  jian he
 <jian.universality@gmail.com>,  Sami Imseih <samimseih@gmail.com>,
  vignesh C <vignesh21@gmail.com>,  Ilia Evdokimov
 <ilya.evdokimov@tantorlabs.com>
Subject: Re: Vacuum statistics
In-Reply-To: <68939c47-fa0c-4198-853a-92d1390079da@yandex.ru> (Alena
	Rybakina's message of "Tue, 17 Mar 2026 19:38:41 +0300")
References: <86f76aa5-1ab5-4e2e-9b15-405051852a2a@postgrespro.ru>
	<f5097647-89f9-4288-9010-9f690778dd53@postgrespro.ru>
	<c43ef413-f65b-46a5-b8a1-28949daaa889@tantorlabs.com>
	<612819ad-beca-41fb-bb7f-d5a7c11f0045@yandex.ru>
	<de4bdbff-a86c-4830-82b1-0c14af2b597d@postgrespro.ru>
	<277ce149-4333-463d-bad6-ccd785606c7f@yandex.ru>
	<3f9c57bc-dc1f-4ad8-a2e1-5be15ac79264@yandex.ru>
	<77f1b8bc-b365-4e88-b87b-ced37fabbbf0@yandex.ru>
	<a6450303-30fe-4d6e-b31a-055dccf09a2b@gmail.com>
	<f4d067c7-8e3e-451a-b13e-28a08b3b871f@gmail.com>
	<7a74d6af-85e2-4b48-9133-61309a965954@yandex.ru>
	<1885f257-46cc-4b90-8d90-41833eb62ea9@gmail.com>
	<0e84acdc-ba65-44fa-be1f-4d6a86bca2ac@yandex.ru>
	<8bd78e04-6efa-4fcf-b157-8ac3b92375c8@yandex.ru>
	<10BE6E39-94D2-4909-ACB8-24E1FA6580EE@yandex-team.ru>
	<4c443e7c-e348-40fc-8baf-2f4caa3b6cbc@yandex.ru>
	<54cbe53b-d8cf-495f-aa33-3501bec72780@moonset.ru>
	<767d28c9-2ae8-43df-9f2e-3e8785075115@yandex.ru>
	<87bjgmlbnf.fsf@desktop.moonset.ru>
	<68939c47-fa0c-4198-853a-92d1390079da@yandex.ru>
Date: Wed, 18 Mar 2026 17:19:03 +0300
Message-ID: <87tsudz0dk.fsf@desktop.moonset.ru>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Archived-At: 
 <https://www.postgresql.org/message-id/87tsudz0dk.fsf%40desktop.moonset.ru>
Precedence: bulk

Alena Rybakina <lena.ribackina@yandex.ru> writes:

> 1. Naming: The meaning of 'visible/frozen_pages_cleared' seems to me as
> cleared pages rather then cleared marks... Maybe it should be
> 'visible_page_marks_cleared'?
>
> I agree, this improves clarity. I've renamed it as proposed. 
>
>  2. Mention of a <command>VACUUM</command> in the docs may be understood
> as related to manual VACUUM command only. However, autovacuum is
> accounted as well.. I think we can use just term 'vacuum' here as a
> facility rather than command.
>
> Fixed. Clarified that this applies to both manual
> <command>VACUUM</command> and autovacuum.

I think it is good now
>
> I also added an additional test scenario where one process holds a
> transaction open while another process deletes tuples. We expect that
> the all-visible and all-frozen flags, previously set by VACUUM, are
> cleared only after the deleting transaction commits and the changes
> become visible.
>

I'm happy with the patch now.
--
Best regards, Andrei Zubkov
Postgres Professional