Feedback-ID: i1ff147bf:Fastmail
From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Thomas Munro <thomas.munro@gmail.com>,  Andres Freund
 <andres@anarazel.de>,  "pgsql-hackers@postgresql.org"
 <pgsql-hackers@postgresql.org>
Subject: Re: Refactoring postmaster's code to cleanup after child exit
References: <835232c0-a5f7-4f20-b95b-5b56ba57d741@iki.fi>
	<a77061d9-1a76-470c-b18c-4f238342d124@iki.fi>
	<8f2118b9-79e3-4af7-b2c9-bd5818193ca4@iki.fi>
	<CA+hUKGKWqSFoJXzRC9D0owFj1Xby0qvWr-k6p8z9gQzT7+nr7w@mail.gmail.com>
	<e9e58efa-a364-4f4f-b112-a11d62af952a@iki.fi>
	<a102f15f-eac4-4ff2-af02-f9ff209ec66f@iki.fi>
	<ebhz2viw6sioxwlhborufqpjbg7ktckgyfplxevh6wfaiesavz@iwzka6fyohev>
	<8e9424ae-2537-411a-a4cd-79760494186e@iki.fi>
	<b892e94c-3511-435a-bc2b-48e052589c16@iki.fi>
	<CA+hUKGLLtH0ZT3+7i9xJzY8wufmqA7y4q9uC2TsGcBHBuRX4sA@mail.gmail.com>
	<217d43af-0287-4769-a825-cde4cfa00e6c@iki.fi>
Date: Sat, 05 Oct 2024 20:51:50 +0100
In-Reply-To: <217d43af-0287-4769-a825-cde4cfa00e6c@iki.fi> (Heikki
	Linnakangas's message of "Sat, 5 Oct 2024 14:45:46 +0300")
Message-ID: <87ttdq9vl5.fsf@wibble.ilmari.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/87ttdq9vl5.fsf%40wibble.ilmari.org>
Precedence: bulk

Heikki Linnakangas <hlinnaka@iki.fi> writes:

> On 05/10/2024 01:03, Thomas Munro wrote:
>
>> It's possible that Windows copied the Linux behaviour for AF_UNIX,
>> given that it probably has something to do with the WSL project for
>> emulating Linux, but IDK.
>
> Sadly Windows' IO::Socket::UNIX hasn't been implemented on Windows (or
> at least on this perl distribution we're using in Cirrus CI):
>
> Socket::pack_sockaddr_un not implemented on this architecture at
> C:/strawberry/5.26.3.1/perl/lib/Socket.pm line 872.
>
> so I'll have to disable this test on Windows anyway.

Socket version 2.028 (included in Perl 5.32) provides pack_sockaddr_un()
on Windows, so that can be fixed by bumping the Perl version in
https://github.com/anarazel/pg-vm-images/blob/main/packer/windows.pkr.hcl
to something more modern (such as 5.40.0.1), and only skipping the test
if on Windows if Socket is too old.

The decision to use 5.26 seems to come from the initial creation of the
CI images in 2021 (when 5.34 was current), with the comment «newer
versions don't currently work correctly for plperl».  That claim is
worth revisiting, and fixing if it's still the case.


- ilmari