Received: from makus.postgresql.org (makus.postgresql.org [98.129.198.125]) by mail.postgresql.org (Postfix) with ESMTP id A3BBA16D90F8 for ; Tue, 27 Mar 2012 16:21:26 -0300 (ADT) Received: from 30.55.colo.spiretech.net ([69.168.55.30] helo=lists.commandprompt.com) by makus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1SCbxM-0006cU-SX for pgsql-hackers@postgresql.org; Tue, 27 Mar 2012 19:21:25 +0000 Received: from clam (spinlock.commandprompt.com [69.168.55.30]) by lists.commandprompt.com (Postfix) with ESMTPA id 39B2124C; Tue, 27 Mar 2012 12:22:03 -0700 (PDT) Received: from clam ([195.88.15.88] helo=clam) by assp.commandprompt.com with ESMTPS(AES128-SHA) (2.1.1); 27 Mar 2012 12:22:01 -0700 From: Alex To: Peter Eisentraut Cc: pgsql-hackers Subject: Re: Another review of URI for libpq, v7 submission References: <87d38eaq3f.fsf@commandprompt.com> <87k42lsgck.fsf@commandprompt.com> <20120317145110.GA25172@gmail.com> <8762dyuda3.fsf@commandprompt.com> <87k42cb9dr.fsf@commandprompt.com> <1332868938.24269.1.camel@vanquo.pezone.net> Date: Tue, 27 Mar 2012 22:21:07 +0300 In-Reply-To: <1332868938.24269.1.camel@vanquo.pezone.net> (Peter Eisentraut's message of "Tue, 27 Mar 2012 20:22:18 +0300") Message-ID: <87ty19kfz0.fsf@commandprompt.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Assp-Version: 2.1.1(11364) on assp.commandprompt.com X-Assp-Client-TLS: yes X-Assp-ID: assp.commandprompt.com m1-76123-09443 X-Assp-Envelope-From: ash@commandprompt.com X-Assp-Intended-For: pgsql-hackers@postgresql.org X-Assp-Original-Subject: Re: [HACKERS] Another review of URI for libpq, v7 submission X-Pg-Spam-Score: -1.1 (-) X-Archive-Number: 201203/1654 X-Sequence-Number: 205535 Peter Eisentraut writes: > On tor, 2012-03-22 at 23:42 +0200, Alex wrote: >> Okay, at last here's v9, rebased against current master branch. > > Attached is a patch on top of your v9 with two small fixes: > > - Don't provide a check target in libpq/Makefile if it's not > implemented. > > - Use the configured port number for running the tests (otherwise it > runs against my system installation, for example). Neat, thank you.