From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,  pgsql-hackers
 <pgsql-hackers@postgresql.org>
Subject: Re: Readd use of TAP subtests
References: <9878e1e2-2ce3-6df0-3498-07d967534f5e@enterprisedb.com>
	<87zgpbnr59.fsf@wibble.ilmari.org>
	<6131CFD1-EC47-41ED-999E-AB28B40DDEAA@yesql.se>
Date: Wed, 08 Dec 2021 14:08:05 +0000
In-Reply-To: <6131CFD1-EC47-41ED-999E-AB28B40DDEAA@yesql.se> (Daniel
	Gustafsson's message of "Wed, 8 Dec 2021 14:53:33 +0100")
Message-ID: <87wnkfnq9m.fsf@wibble.ilmari.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/87wnkfnq9m.fsf%40wibble.ilmari.org>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:

>> On 8 Dec 2021, at 14:49, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> wrote:
>> 
>> Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
>> 
>>> Now that subtests in TAP are supported again, I want to correct the
>>> great historical injustice of 7912f9b7dc9e2d3f6cd81892ef6aa797578e9f06 
>>> and put those subtests back.
>> 
>> The updated Test::More version requirement also gives us done_testing()
>> (added in 0.88), which saves us from the constant maintenance headache
>> of updating the test counts every time.  Do you fancy switching the
>> tests you're modifying anyway to that?
>
> We already call done_testing() in a number of tests, and have done so for a
> number of years.  src/test/ssl/t/002_scram.pl is one example.

Reading the Test::More changelog more closely, it turns out that even
though we used to depend on version 0.87, that's effectively equivalent
0.88, because there was no stable 0.87 release, only 0.86 and
development releases 0.87_01 through _03.

Either way, I think we should be switching tests to done_testing()
whenever it would otherwise have to adjust the test count, to avoid
having to do that again and again and again going forward.

- ilmari