Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wA5U0-0023EZ-1m for pgsql-hackers@arkaria.postgresql.org; Tue, 07 Apr 2026 12:24:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wA5Ty-00H7Ay-02 for pgsql-hackers@arkaria.postgresql.org; Tue, 07 Apr 2026 12:24:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wA5Tx-00H7An-08 for pgsql-hackers@lists.postgresql.org; Tue, 07 Apr 2026 12:24:38 +0000 Received: from fhigh-b5-smtp.messagingengine.com ([202.12.124.156]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wA5Tt-000000015sc-4BdZ for pgsql-hackers@postgresql.org; Tue, 07 Apr 2026 12:24:37 +0000 Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfhigh.stl.internal (Postfix) with ESMTP id 72E437A01BC; Tue, 7 Apr 2026 08:24:31 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Tue, 07 Apr 2026 08:24:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilmari.org; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1775564671; x=1775651071; bh=lh9LNamyN2 Ee6dyh1sLG02cc/d7sYM27b7hEwdfD088=; b=n8LZjUARKWYhQGjLtl0F0or0E6 JNvlFsayRaUJoviNw2ARVdltZdadpzyMgkMq9tmUjgNUAVv8Fb91QRwjxV4yZYUT hPJUHrsGiBfdobQOmVfXZaemHPQhdqcpo2LlpnyDjEikQxvwuSXWshFJ/xBoe5HP L5MlzuQo6/xKhbNOWAxGWQnktJdgwlC22jp85JobcJ54f6FIEWdh3u+Z0cpQ5aPn vHnH+OejOFms3Ug0FoG38jsqdAjgRvvxjbvsFd+htLfIhRtOqDGLPXQNZscY4ybj /H4MWq3VC1aApWQWofnzn4wI4Mv6q2Cs1UrtbQGYlNZPCWGquMlqUrQPUA/Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1775564671; x=1775651071; bh=lh9LNamyN2Ee6dyh1sLG02cc/d7sYM27b7h EwdfD088=; b=GhpbzZyO2PKCswFqe8GJuB6BeNau9g4OY5KKwe9NICmaZYfihtV GUJJXBWFaZaCdnadOVezcOqDhuHMJfRoTK+zAJxkvQATgJdZD/wpjsWg+3U+A1dd HMAtzgCJMwFyvJ2TEWp7KUPF3JnmK4KpsvzEGybdgMNb9HrWrTUrJzHoaXqbmcju 9KBZXY5reXyqMUd3IWvTfjYfdP8lhj38xhp6fc9befzJkXfgAeDOpK7jSd0RkE/4 IjIPYhCWKOdGC3QruLzQYH2RYKxtcXcwZ6Ya/kL/Vh9e9TwGnN3XYg4s1/OUZI8N RDH/RYfQ1A25TcmnmZu1bA+MBB4J6Sg+C2w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgddvtdeifecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufhfffgjkfgfgggtsehttdertddtreejnecuhfhrohhmpeffrghgfhhinhhn ucfklhhmrghrihcuofgrnhhnshonkhgvrhcuoehilhhmrghrihesihhlmhgrrhhirdhorh hgqeenucggtffrrghtthgvrhhnpeekleejueefhfffkefhkedtfeeluedvieeihfehfeef feeggeduffduheejjeeigfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehilhhmrghrihesihhlmhgrrhhirdhorhhgpdhnsggprhgtphhtthho peeipdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegthhgrthhurhhvvgguihhprg hlrghkudeluddusehgmhgrihhlrdgtohhmpdhrtghpthhtohepphhgshhqlhdqhhgrtghk vghrshesphhoshhtghhrvghsqhhlrdhorhhgpdhrtghpthhtoheprghnughrvghssegrnh grrhgriigvlhdruggvpdhrtghpthhtoheprhhosggvrhhtmhhhrggrshesghhmrghilhdr tghomhdprhgtphhtthhopegrshhhuhhtohhshhdrsggrphgrthdrohhsshesghhmrghilh drtghomhdprhgtphhtthhopehhlhhinhhnrghkrgesihhkihdrfhhi X-ME-Proxy: Feedback-ID: i1ff147bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 Apr 2026 08:24:29 -0400 (EDT) From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= To: Heikki Linnakangas Cc: Ashutosh Bapat , Robert Haas , Andres Freund , pgsql-hackers , chaturvedipalak1911@gmail.com Subject: Re: Better shared data structure management and resizable shared data structures References: <8a6799be-bd42-49fb-8914-856c97bb1977@iki.fi> <113724ab-0028-493f-9605-6e8570f0939f@iki.fi> <791c3f18-f4de-4d84-ac6b-c7ccc074dd38@iki.fi> <9d919bd9-94dd-4bda-8ccf-ebced4178c53@iki.fi> <470e7ebe-0971-49f6-8e46-9b8f6395f88b@iki.fi> Date: Tue, 07 Apr 2026 13:24:28 +0100 In-Reply-To: <470e7ebe-0971-49f6-8e46-9b8f6395f88b@iki.fi> (Heikki Linnakangas's message of "Sat, 4 Apr 2026 03:49:25 +0300") Message-ID: <87y0iz2c1v.fsf@wibble.ilmari.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Heikki Linnakangas writes: > Those are now committed, and here's a new version rebased over those > changes. I noticed this bit during my habitual morning skim of new commits: > diff --git a/src/backend/utils/misc/injection_point.c b/src/backend/utils/misc/injection_point.c > index c06b0e9b800..9981d6e212f 100644 > --- a/src/backend/utils/misc/injection_point.c > +++ b/src/backend/utils/misc/injection_point.c > @@ -17,6 +17,7 @@ > */ > #include "postgres.h" > > +#include "storage/subsystems.h" > #include "utils/injection_point.h" > > #ifdef USE_INJECTION_POINTS > @@ -109,6 +110,11 @@ typedef struct InjectionPointCacheEntry > > static HTAB *InjectionPointCache = NULL; > > +#ifdef USE_INJECTION_POINTS > +static void InjectionPointShmemRequest(void *arg); > +static void InjectionPointShmemInit(void *arg); > +#endif > + This is already inside an `#ifdef USE_INJECTION_POINTS` guard (in fact visible at the end of the previous diff hunk), no need for another one. - ilmari