Feedback-ID: i1ff147bf:Fastmail
From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: Japin Li <japinli@hotmail.com>,  Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: test_escape: invalid option -- 'c'
References: <ME0P300MB04451FB20CE0346A59C25CADB6FA2@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM>
	<Z7QCqkGKLCRi-6ik@paquier.xyz>
Date: Tue, 18 Feb 2025 13:11:11 +0000
In-Reply-To: <Z7QCqkGKLCRi-6ik@paquier.xyz> (Michael Paquier's message of
	"Tue, 18 Feb 2025 12:46:50 +0900")
Message-ID: <87y0y31jps.fsf@wibble.ilmari.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Archived-At: <https://www.postgresql.org/message-id/87y0y31jps.fsf%40wibble.ilmari.org>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:

> On Tue, Feb 18, 2025 at 11:12:13AM +0800, Japin Li wrote:
>> When I test test_escape, I find the usage of test_escape declares it
>> support -c option, however, when I use it, it complains it is an
>> invalid option.
>> 
>> Here is a patch to fix it.
>
> You are right, obviously.  The only reason why this is not showing up
> is that the TAP test uses the long option --conninfo.

This was something I did consider when porting the tests to use long
options: should we leave (or add) at least one usage of every
corresponding shor option, for exactly this reason?

> Speaking of which, this had better use fat commas to combine the
> option/value pairs in these commands.

I have a local branch which converts more of the tests to the long and
fat style, I'll try to finish that up for submission soon, and look at
adding/retaining coverage for short options.

- ilmari