Feedback-ID: i1ff147bf:Fastmail
From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
  pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Refactor construct_array() and deconstruct_array() for built-in
 types
References: <2914356f-9e5f-8c59-2995-5997fc48bcba@enterprisedb.com>
	<1844517.1651502932@sss.pgh.pa.us>
	<c030a2ef-02d6-ccdb-8ebe-bc97df69be59@enterprisedb.com>
	<871qv5kt9y.fsf@wibble.ilmari.org>
Date: Fri, 01 Jul 2022 11:47:50 +0100
In-Reply-To: <871qv5kt9y.fsf@wibble.ilmari.org> ("Dagfinn Ilmari
 =?utf-8?Q?Manns=C3=A5ker=22's?=
	message of "Fri, 01 Jul 2022 11:43:21 +0100")
Message-ID: <87y1xdjei1.fsf@wibble.ilmari.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/87y1xdjei1.fsf%40wibble.ilmari.org>
Precedence: bulk

Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> writes:

> I dind't pay much attention to this thread earlier, but I was struck by
> the duplication of the switch statement determining the elemlen,
> elembyval, and elemalign values between the construct and deconstruct
> functions.  How about a common function they can both call?  Something
> like:
>
> static void builtin_type_details(Oid elemtype,
>                                  int *elemlen,
>                                  bool *elembyval,
>                                  char *elemalign);

I just realised that this would require the error message to not include
the function name (which isn't really that critical, since it's a
developer-facing message), but an option would to make it return false
for unknown types, so each of the calling functions can emit their own
error message.

> - ilmari