From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: Bruce Momjian <bruce@momjian.us>, Justin Pryzby <pryzby@telsasoft.com>,
        pgsql-hackers@lists.postgresql.org,
        Daniel Gustafsson <daniel@yesql.se>
Subject: Re: format of pg_upgrade loadable_libraries warning
In-reply-to: <20191114190652.GA23586@alvherre.pgsql>
References: <20191114190652.GA23586@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@2ndquadrant.com>
	message dated "Thu, 14 Nov 2019 16:06:52 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8831.1573760789.1@sss.pgh.pa.us>
Date: Thu, 14 Nov 2019 14:46:29 -0500
Message-ID: <8832.1573760789@sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2019-Oct-07, Bruce Momjian wrote:
>> and the "in database" (which I have changed to capitalized "In database"
>> in the attached patch), looks like:
>> fprintf(script, "In database: %s\n", active_db->db_name);
>> meaning it _isn't_ an output error message, but rather something that
>> appears in an error file.  I don't think either of these are translated.
>> Is that wrong?

> pg_fatal is a "gettext trigger" (see nls.mk), so that part of the
> message is definitely translated.

Right, but Bruce's point is that what goes into the separate output
file listing problem cases is not translated, and never has been.
Maybe we should start doing so, but that would be a distinct issue.
I'm not really sure that we should translate it, anyway --- could
there be anyone out there who is using tools to process these files?

> BTW, how is one supposed to "manually upgrade databases that use
> contrib/isb"?  This part is not very clear.

Agreed, the pg_fatal message is claiming that you can do something
without really providing any concrete instructions for it.  I'm not
sure that that's helpful.

			regards, tom lane