Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h2BbO-0002Af-1h for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Mar 2019 09:15:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h2BbL-0005KI-9P for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Mar 2019 09:15:35 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h2BbK-0005Dm-Ti for pgsql-hackers@lists.postgresql.org; Fri, 08 Mar 2019 09:15:35 +0000 Received: from mx1.mailbox.org ([80.241.60.212]) by makus.postgresql.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h2BbG-0005xX-9r for pgsql-hackers@postgresql.org; Fri, 08 Mar 2019 09:15:33 +0000 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx1.mailbox.org (Postfix) with ESMTPS id 4E2BD4BC95; Fri, 8 Mar 2019 10:15:27 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id AOGxvGvwlZ3q; Fri, 8 Mar 2019 10:15:23 +0100 (CET) Message-ID: <883a99846d67e3c192534513b73c219e8f5254c7.camel@cybertec.at> Subject: Re: Small doc fix for pageinspect From: Laurenz Albe To: Michael Paquier Cc: pgsql-hackers@postgresql.org Date: Fri, 08 Mar 2019 10:15:21 +0100 In-Reply-To: <20190308061300.GH4099@paquier.xyz> References: <8f9ab7b16daf623e87eeef5203a4ffc0dece8dfd.camel@cybertec.at> <20190308061300.GH4099@paquier.xyz> Organization: Cybertec Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Michael Paquier wrote: > On Thu, Mar 07, 2019 at 09:00:24PM +0100, Laurenz Albe wrote: > > This should be backpatched down to 9.6 where the functions have been > > added. > > Thanks, applied. The second argument name of heap_page_item_attrs is > actually "page", and not "t_data", so both your patch and the docs > were wrong on this point. Thanks, and pardon the sloppiness. Yours, Laurenz Albe