Feedback-ID: i0c21471d:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-172-g9a2dae1853-fm-20230213.001-g9a2dae18
Mime-Version: 1.0
Message-Id: <8851e7ad-a1ff-4827-9805-9ba73b289e7f@app.fastmail.com>
In-Reply-To: <7e53071e-8451-9210-272a-e91c7b00df9c@enterprisedb.com>
References: <20230224191840.GD1653@telsasoft.com>
 <7e53071e-8451-9210-272a-e91c7b00df9c@enterprisedb.com>
Date: Sat, 25 Feb 2023 11:47:26 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: "Tomas Vondra" <tomas.vondra@enterprisedb.com>,
 "Justin Pryzby" <pryzby@telsasoft.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: gkokolatos@pm.me, "Michael Paquier" <michael@paquier.xyz>,
 "Robert Haas" <robertmhaas@gmail.com>, "Peter Geoghegan" <pg@bowt.ie>,
 "Peter Eisentraut" <peter.eisentraut@enterprisedb.com>,
 "Heikki Linnakangas" <hlinnaka@iki.fi>,
 "Thomas Munro" <thomas.munro@gmail.com>,
 "Dipesh Pandit" <dipesh.pandit@gmail.com>,
 "Andrey Borodin" <x4mmm@yandex-team.ru>,
 "Mark Dilger" <mark.dilger@enterprisedb.com>
Subject: Re: zstd compression for pg_dump
Content-Type: multipart/alternative;
 boundary=48a63bf6282244cfafa0375008a30723
Archived-At: <https://www.postgresql.org/message-id/8851e7ad-a1ff-4827-9805-9ba73b289e7f%40app.fastmail.com>
Precedence: bulk

--48a63bf6282244cfafa0375008a30723
Content-Type: text/plain

On Sat, Feb 25, 2023, at 7:31 AM, Tomas Vondra wrote:
> On 2/24/23 20:18, Justin Pryzby wrote:
> > This is a draft patch - review is welcome and would help to get this
> > ready to be considererd for v16, if desired.
> > 
> > I'm going to add this thread to the old CF entry.
> > https://commitfest.postgresql.org/31/2888/
> > 
> 
> Thanks. Sadly cfbot is unhappy - the windows and cplusplus builds failed
> because of some issue in pg_backup_archiver.h. But it's a bit bizarre
> because the patch does not modify that file at all ...
cpluspluscheck says

        # pg_dump is not C++-clean because it uses "public" and "namespace"
        # as field names, which is unfortunate but we won't change it now.

Hence, the patch should exclude the new header file from it.

--- a/src/tools/pginclude/cpluspluscheck
+++ b/src/tools/pginclude/cpluspluscheck
@@ -153,6 +153,7 @@ do
    test "$f" = src/bin/pg_dump/compress_gzip.h && continue
    test "$f" = src/bin/pg_dump/compress_io.h && continue
    test "$f" = src/bin/pg_dump/compress_lz4.h && continue
+   test "$f" = src/bin/pg_dump/compress_zstd.h && continue
    test "$f" = src/bin/pg_dump/compress_none.h && continue
    test "$f" = src/bin/pg_dump/parallel.h && continue
    test "$f" = src/bin/pg_dump/pg_backup_archiver.h && continue


--
Euler Taveira
EDB   https://www.enterprisedb.com/

--48a63bf6282244cfafa0375008a30723
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Sat, Feb 25,=
 2023, at 7:31 AM, Tomas Vondra wrote:<br></div><blockquote type=3D"cite=
" id=3D"qt" style=3D""><div>On 2/24/23 20:18, Justin Pryzby wrote:<br></=
div><div>&gt; This is a draft patch - review is welcome and would help t=
o get this<br></div><div>&gt; ready to be considererd for v16, if desire=
d.<br></div><div>&gt;&nbsp;<br></div><div>&gt; I'm going to add this thr=
ead to the old CF entry.<br></div><div>&gt;&nbsp;<a href=3D"https://comm=
itfest.postgresql.org/31/2888/">https://commitfest.postgresql.org/31/288=
8/</a><br></div><div>&gt;&nbsp;<br></div><div><br></div><div>Thanks. Sad=
ly cfbot is unhappy - the windows and cplusplus builds failed<br></div><=
div>because of some issue in pg_backup_archiver.h. But it's a bit bizarr=
e<br></div><div>because the patch does not modify that file at all ...<b=
r></div></blockquote><div>cpluspluscheck says<br></div><div><br></div><d=
iv>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; # pg_dump is not C++-clean=
 because it uses "public" and "namespace"<br></div><div>&nbsp;&nbsp;&nbs=
p;&nbsp;&nbsp;&nbsp;&nbsp; # as field names, which is unfortunate but we=
 won't change it now.<br></div><div><br></div><div>Hence, the patch shou=
ld exclude the new header file from it.<br></div><div><br></div><div>---=
 a/src/tools/pginclude/cpluspluscheck<br></div><div>+++ b/src/tools/pgin=
clude/cpluspluscheck<br></div><div>@@ -153,6 +153,7 @@ do<br></div><div>=
&nbsp;&nbsp;&nbsp; test "$f" =3D src/bin/pg_dump/compress_gzip.h &amp;&a=
mp; continue<br></div><div>&nbsp;&nbsp;&nbsp; test "$f" =3D src/bin/pg_d=
ump/compress_io.h &amp;&amp; continue<br></div><div>&nbsp;&nbsp;&nbsp; t=
est "$f" =3D src/bin/pg_dump/compress_lz4.h &amp;&amp; continue<br></div=
><div>+&nbsp;&nbsp; test "$f" =3D src/bin/pg_dump/compress_zstd.h &amp;&=
amp; continue<br></div><div>&nbsp;&nbsp;&nbsp; test "$f" =3D src/bin/pg_=
dump/compress_none.h &amp;&amp; continue<br></div><div>&nbsp;&nbsp;&nbsp=
; test "$f" =3D src/bin/pg_dump/parallel.h &amp;&amp; continue<br></div>=
<div>&nbsp;&nbsp;&nbsp; test "$f" =3D src/bin/pg_dump/pg_backup_archiver=
.h &amp;&amp; continue<br></div><div></div><div><br></div><div><br></div=
><div id=3D"sig112409080"><div class=3D"signature">--<br></div><div clas=
s=3D"signature">Euler Taveira<br></div><div class=3D"signature">EDB&nbsp=
;&nbsp; <a href=3D"https://www.enterprisedb.com/">https://www.enterprise=
db.com/</a><br></div></div><div><br></div></body></html>
--48a63bf6282244cfafa0375008a30723--