Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gIEc4-0007OC-Sm for pgsql-hackers@arkaria.postgresql.org; Thu, 01 Nov 2018 15:10:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gIEc3-0004LF-3K for pgsql-hackers@arkaria.postgresql.org; Thu, 01 Nov 2018 15:10:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gIEc2-0004Kt-S5 for pgsql-hackers@lists.postgresql.org; Thu, 01 Nov 2018 15:10:22 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gIEc0-0002Tx-Co for pgsql-hackers@lists.postgresql.org; Thu, 01 Nov 2018 15:10:22 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id wA1FAEwM008872; Thu, 1 Nov 2018 11:10:15 -0400 From: Tom Lane To: Robert Haas cc: Nikolay Shaplov , PostgreSQL Hackers , Alvaro Herrera , Nikita Glukhov , "pgsql-hackers@postgresql.org" Subject: Re: [PATCH][PROPOSAL] Add enum releation option type In-reply-to: References: <20180301174735.yyu6i5y66u3xp3jc@alvherre.pgsql> <12291633.PFnvXaAOpE@x200m> Comments: In-reply-to Robert Haas message dated "Thu, 01 Nov 2018 10:58:04 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <8870.1541085014.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Thu, 01 Nov 2018 11:10:14 -0400 Message-ID: <8871.1541085014@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Robert Haas writes: > On Wed, Mar 7, 2018 at 10:23 AM Nikolay Shaplov wrote= : >>> I see you lost the Oxford comma: >>> = >>> -DETAIL: Valid values are "on", "off", and "auto". >>> +DETAIL: Valid values are "auto", "on" and "off". >>> = >>> Please put these back. >> Actually that's me who have lost it. The code with oxford comma would = be a >> bit more complicated. We should put such coma when we have 3+ items and= do not >> put it when we have 2. >> = >> Does it worth it? > In my opinion, it is worth it. Uh ... I've not been paying attention to this thread, but this exchange seems to be about somebody constructing a message like that piece-by-piece in code. This has got to be a complete failure from the translatability standpoint. See https://www.postgresql.org/docs/devel/static/nls-programmer.html#NLS-GUIDE= LINES regards, tom lane