From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Gilman <dgilman@gilslotd.com>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Warn when parallel restoring a custom dump without data offsets
In-reply-to: <20200528003347.tut2sg2lhfb2i5xv@dar.local>
References: <20200519130740.GO18456@telsasoft.com>
 <CALBH9DDpO8dyttAx34_pu4dPXphm+k8Ca0ee+-1e7A+vXx4emQ@mail.gmail.com>
 <CAOaQA5xsa7KTsX3js5mt00Do+AiarQb5qd4ZYM3AR_NwXtFzeg@mail.gmail.com>
 <CALBH9DAmhfBw=VsKCcmig9jP2pBtuyLU5U5Tun_G=3ULs+q-dg@mail.gmail.com>
 <25161.1589986110@sss.pgh.pa.us>
 <CALBH9DBsWbwAXseNJdk4DbH1aR=sdczyAirp1aSxjpBSi86FzA@mail.gmail.com>
 <CALBH9DBYLxYxA7-=CZNa0K_Sg4wCv=RHFJDxOcSW8cZB5orezQ@mail.gmail.com>
 <20200523224751.GP4472@telsasoft.com>
 <20200525185429.6pp5vdvfu3vxlwac@dar.local>
 <20200525215526.t7dqywfywxzmlpbu@dar.local>
 <20200528003347.tut2sg2lhfb2i5xv@dar.local>
Comments: In-reply-to David Gilman <dgilman@gilslotd.com>
	message dated "Wed, 27 May 2020 19:33:47 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <888846.1593725121.1@sss.pgh.pa.us>
Date: Thu, 02 Jul 2020 17:25:21 -0400
Message-ID: <888847.1593725121@sss.pgh.pa.us>
Precedence: bulk

David Gilman <dgilman@gilslotd.com> writes:
> I've attached the latest patches after further review from Justin Pryzby.

I guess I'm completely confused about the purpose of these patches.
Far from coping with the situation of an unseekable file, they appear
to change pg_restore so that it fails altogether if it can't seek
its input file.  Why would we want to do this?

			regards, tom lane