Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lElL6-0002AK-BD for pgsql-hackers@arkaria.postgresql.org; Wed, 24 Feb 2021 03:59:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lElL2-0002j9-Jn for pgsql-hackers@arkaria.postgresql.org; Wed, 24 Feb 2021 03:59:48 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lElL2-0002j1-D4 for pgsql-hackers@lists.postgresql.org; Wed, 24 Feb 2021 03:59:48 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lElKu-0003Lk-Nk for pgsql-hackers@lists.postgresql.org; Wed, 24 Feb 2021 03:59:47 +0000 Received: from hnk.local (p2710230-ipbf1703funabasi.chiba.ocn.ne.jp [123.216.93.230]) by oss.nttdata.com (Postfix) with ESMTPSA id 8EE7A627A3; Wed, 24 Feb 2021 12:59:34 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.3 at oss.nttdata.com Subject: Re: [PATCH] Feature improvement for TRUNCATE tab completion. To: Muhammad Usama , pgsql-hackers@lists.postgresql.org Cc: Kota Miyake References: <161401224339.29967.15380917401849453247.pgcf@coridan.postgresql.org> From: Fujii Masao Message-ID: <8888efc8-203f-ddc1-aba3-3ea27ba84bfd@oss.nttdata.com> Date: Wed, 24 Feb 2021 12:59:34 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <161401224339.29967.15380917401849453247.pgcf@coridan.postgresql.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2021/02/23 1:44, Muhammad Usama wrote: > The following review has been posted through the commitfest application: > make installcheck-world: not tested > Implements feature: tested, passed > Spec compliant: tested, passed > Documentation: not tested > > Other than "Hunk #1 succeeded at 3832 (offset 33 lines)." message while applying the patch to > current master branch (commit 6a03369a71d4a7dc5b8d928aab775ddd28b72494) I found no issue with the patch. > > The new status of this patch is: Ready for Committer OK, so barring any objection, I will commit this patch. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION