Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfTNJ-0004uB-7H for pgsql-hackers@arkaria.postgresql.org; Sun, 19 Feb 2017 15:26:09 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cfTNI-0006gI-Qo for pgsql-hackers@arkaria.postgresql.org; Sun, 19 Feb 2017 15:26:08 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cfTNI-0006g9-4v for pgsql-hackers@postgresql.org; Sun, 19 Feb 2017 15:26:08 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cfTNG-0001rx-4b for pgsql-hackers@postgresql.org; Sun, 19 Feb 2017 15:26:06 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v1JFQ46j000890; Sun, 19 Feb 2017 10:26:04 -0500 From: Tom Lane To: Robert Haas cc: "pgsql-hackers@postgresql.org" Subject: Re: Suppressing that pesky warning with older flex versions In-reply-to: References: <25456.1487437842@sss.pgh.pa.us> Comments: In-reply-to Robert Haas message dated "Sun, 19 Feb 2017 14:24:02 +0530" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <888.1487517964.1@sss.pgh.pa.us> Date: Sun, 19 Feb 2017 10:26:04 -0500 Message-ID: <889.1487517964@sss.pgh.pa.us> X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Robert Haas writes: > On Sat, Feb 18, 2017 at 10:40 PM, Tom Lane wrote: >> It seems like it would be quite simple and reliable to apply a patch >> that inserts "(void) yyg;" into this function. (Which, indeed, is >> essentially how flex 2.5.36 and later fixed it.) > Sounds fine as a master-only fix, but I would vote against back-patching. Agreed. I see no need to change this in stable branches; having -Werror everywhere is mainly of value for development. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers