Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nYAfc-0000UB-AT for pgsql-hackers@arkaria.postgresql.org; Sat, 26 Mar 2022 17:57:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nYAfZ-0002Ts-KR for pgsql-hackers@arkaria.postgresql.org; Sat, 26 Mar 2022 17:57:45 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nYAfZ-0002Tj-B7 for pgsql-hackers@lists.postgresql.org; Sat, 26 Mar 2022 17:57:45 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nYAfW-0006cs-R1 for pgsql-hackers@postgresql.org; Sat, 26 Mar 2022 17:57:43 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 22QHvdmS088927; Sat, 26 Mar 2022 13:57:39 -0400 From: Tom Lane To: Andres Freund cc: Michael Paquier , Jacob Champion , "rjuju123@gmail.com" , "pgsql-hackers@postgresql.org" , "sfrost@snowman.net" Subject: Re: [PATCH] Expose port->authn_id to extensions and triggers In-reply-to: <20220326171550.ywohmkvngh4qc2fo@alap3.anarazel.de> References: <973625.1647556418@sss.pgh.pa.us> <60ce6b04f2e4049d04700730f1c439e325731dc4.camel@vmware.com> <2886824.1648076428@sss.pgh.pa.us> <8a480a78f24a10a83f58e1ce5d462b0a93412a99.camel@vmware.com> <20220323235436.2fx2d67s6gztlb2p@alap3.anarazel.de> <94c53220cb1e8a7a9c411fd14bfc64ff3b65d68d.camel@vmware.com> <20220326171550.ywohmkvngh4qc2fo@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Sat, 26 Mar 2022 10:15:50 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <88925.1648317459.1@sss.pgh.pa.us> Date: Sat, 26 Mar 2022 13:57:39 -0400 Message-ID: <88926.1648317459@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2022-03-26 15:18:59 +0900, Michael Paquier wrote: >> On Thu, Mar 24, 2022 at 05:44:06PM +0000, Jacob Champion wrote: >>> On Wed, 2022-03-23 at 16:54 -0700, Andres Freund wrote: >>>> Another option would be to make it a GUC. With a bit of care it could be >>>> automatically synced by the existing parallelism infrastructure... >>> Like a write-once, PGC_INTERNAL setting? > Perhaps PGC_INTERNAL, perhaps PGC_SU_BACKEND, set with PGC_S_OVERRIDE? Seems like making it a GUC does nothing to fix the complaint you had about passing data to workers whether it's needed or not. Sure, we don't then need to write any new code for it, but it's still new cycles. And it's new cycles all throughout guc.c, too, not just in parallel worker start. I also note that exposing it as a GUC means we have zero control over who/what can read it. Maybe that's not a problem, but it needs to be thought about before we go down that path. regards, tom lane