Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.300.41.1.7\))
Subject: Re: brin: Remove duplicate initialization in
 initialize_brin_buildstate()
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <CAOzEurT07FUyHnxpY=CXia2z3eto1APA4RpE=zhb7=-tmhHGPg@mail.gmail.com>
Date: Wed, 11 Feb 2026 10:32:32 +0800
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <889A68D5-15E9-4B98-BDED-91DAAB80477A@gmail.com>
References: <CAEoWx2nmrca6-9SNChDvRYD6+r==fs9qg5J93kahS7vpoq8QVg@mail.gmail.com>
 <CAOzEurT07FUyHnxpY=CXia2z3eto1APA4RpE=zhb7=-tmhHGPg@mail.gmail.com>
To: Shinya Kato <shinya11.kato@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/889A68D5-15E9-4B98-BDED-91DAAB80477A%40gmail.com>
Precedence: bulk


> On Feb 11, 2026, at 09:23, Shinya Kato <shinya11.kato@gmail.com> =
wrote:
>=20
> On Wed, Jan 21, 2026 at 3:30=E2=80=AFPM Chao Li =
<li.evan.chao@gmail.com> wrote:
>>=20
>> Hi Hacker,
>>=20
>> Just noticed a redundant assignment in initialize_brin_buildstate():
>>=20
>> ```
>> static BrinBuildState *
>> initialize_brin_buildstate(Relation idxRel, BrinRevmap *revmap,
>>  BlockNumber pagesPerRange, BlockNumber tablePages)
>> {
>> BrinBuildState *state;
>> BlockNumber lastRange =3D 0;
>>=20
>> state =3D palloc_object(BrinBuildState);
>>=20
>>        <=E2=80=A6omit some lines=E2=80=A6>
>>=20
>> // Later, b437571 added the same again. This patch deletes these 3 =
lines.
>> state->bs_context =3D CurrentMemoryContext;
>> state->bs_emptyTuple =3D NULL;
>> state->bs_emptyTupleLen =3D 0;
>>=20
>> // Added by dae761a first
>> /* Remember the memory context to use for an empty tuple, if needed. =
*/
>> state->bs_context =3D CurrentMemoryContext;
>> state->bs_emptyTuple =3D NULL;
>> state->bs_emptyTupleLen =3D 0;
>> ```
>>=20
>> So, filing a trivial patch to eliminate the redundancy.
>=20
> Thank you for the patch! It looks good to me, so I=E2=80=99ve marked =
the entry
> as Ready for Committer.
>=20
> --=20
> Best regards,
> Shinya Kato
> NTT OSS Center

Thanks a lot.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/