Content-Type: multipart/alternative;
 boundary="------------xQ3EypWBR83lZYAIGHJHJjIA"
Message-ID: <88a392fd-d732-45a7-bcfc-291258849fbe@dunslane.net>
Date: Thu, 2 Apr 2026 15:21:54 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim,
 replace, split_part
To: "David E. Wheeler" <david@justatheory.com>
Cc: Florents Tselai <florents.tselai@gmail.com>,
 pgsql-hackers <pgsql-hackers@lists.postgresql.org>,
 Chao Li <li.evan.chao@gmail.com>, =?UTF-8?Q?=C3=81lvaro_Herrera?=
 <alvherre@kurilemu.de>, Tom Lane <tgl@sss.pgh.pa.us>,
 Peter Eisentraut <peter@eisentraut.org>, Robert Haas
 <robertmhaas@gmail.com>, Alexander Korotkov <aekorotkov@gmail.com>,
 jian he <jian.universality@gmail.com>
References: <202510210803.3b3vfvygxtjl@alvherre.pgsql>
 <3DC56A6A-9525-4C05-B45A-9A135A66BC34@justatheory.com>
 <CACJufxGAmcwq33nr_MmgnGdGo7E10c55kCA22DQ4n9FBUOZmTA@mail.gmail.com>
 <A654130B-16AF-4E37-9D73-B3CDC80C751C@justatheory.com>
 <CACJufxEphbmEWLKzYNfzsyEB5+bkbMAMUHJq2LxpDdcSZn98BA@mail.gmail.com>
 <CACJufxGdgxyRLd03wM=GtJzUskXnXxEBGGtwA2vsTvkV827SxA@mail.gmail.com>
 <CACJufxHxWKhNcTsmYz428yxUikeUVZz=o6mLNRXpB7F_1oDEng@mail.gmail.com>
 <CECA8C06-755C-4550-88C8-0E1E0CB03D64@justatheory.com>
 <DB26FD47-DF09-4A92-AA15-08F012ED0DE2@justatheory.com>
 <CA+v5N40aRmC3DYzWDxTbQKMKohkTdMZJ92Nuaj_NniKS7RHpEA@mail.gmail.com>
 <931F201B-FF38-486E-BDEE-DF9692A01E1D@justatheory.com>
 <D81098C5-CB6D-47BE-995B-A451BE396525@justatheory.com>
 <1eb15091-660d-477b-acda-b61d00bc9ffb@dunslane.net>
 <278cb771-6008-44e5-8eaa-9d4acdb56c79@dunslane.net>
 <9E9B3C10-7535-4704-A04A-DF5D32C43DBE@justatheory.com>
 <b3c965ea-89c1-4ef1-a2a9-29854345f96d@dunslane.net>
 <34758556-D3D0-42C3-9A1B-CBF64336ADBC@justatheory.com>
From: Andrew Dunstan <andrew@dunslane.net>
Content-Language: en-US
Autocrypt: addr=andrew@dunslane.net; keydata=
 xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI
 gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq
 Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C
 eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys
 SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB
 AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAlwQTAQgAQQIbAwIX
 gAIZAQULCQgHAwUVCgkICwUWAgMBAAIeBRYhBOQ+WEYd/Hy/RGkVpZn6f8tZ/DuBBQJoGNGd
 BQkdEO8nAAoJEJn6f8tZ/DuBq74H/jkTR4Zi3stbw+xC7v2u3QozssK7MYPL2AsVfh7OealS
 h182fiWXpfvmmAB7WUHbhk9GC2RAOnHI/2d2jgKaMLAHsGYOT0YopTVIwRY43fCw/mK67yxc
 wmDcX+zyKfLaivNbf5A7QPLNwda98bEAMSJ8Sn652Uc6cA8t3uKGsVzbRBQOoYzjgvBCfSrE
 9ql3PDNg0l4BfAqabd2f70ZUm9VAMEPrgv/v2xI7M2XiL4g5BVmqLCOwxLM8RMCotCuoweUr
 VO43DeBCIDwLxotMJKvGWDjBzQYlU1NPUAtNcz/gN9ITUe1VUGjyvGj4u1lxBOcQQUw7l1+T
 5moZ4iZxXzvOwE0ETspYWQEIANGc4zQULOxhbqO2dyD51YhqCNRmm9oKWaqf+wmW4tpDe/VV
 cxAnNizd4LWCHfzpb5cHAtGkOPePMfzWVf6nvdF7d3eglbtf59+zG7O7llV0xSSoFiieQBsr
 GvqDInXYX/4mRRXMtyhM353/tixC9RWLs1oofyYmCPPXXY7h9R7en3B8BoVrRFcdzlIY/NFN
 hFGW/9dkEiGjgna2Rk6e15kln4ZvFBWUg23p93w/pqXcxY6+k/8TEk+C4R+M6w7o2PLGOjdZ
 +kPiUcw5H85zf/yZJwQXzisXaNduwWB6Vads9YC9dj6kPR1c4VGRqAaYL++LAEOqrlvm2Tvq
 QqZRtnEAEQEAAcLAfAQYAQgAJgIbDBYhBOQ+WEYd/Hy/RGkVpZn6f8tZ/DuBBQJoGNI2BQkd
 EODdAAoJEJn6f8tZ/DuBfw0IAKTsfD40teP/pp+bsLLMSxPXUYrrprTj7WFB5v61p6dkpSr/
 qXmMlyahdxQFaPmfVgVirB1Vk/kHiWNnnGjfUV9nB2Zg9LI0Xb9/ts3LsUiRWXzG3tkMY6XL
 vsVOxW4XFRND9l2q+WW93aZ1DZl+fqWfYgMvsusFRhmGFOKTRfKPta2Pkv+AhA24N4+PrR5p
 bU4k2MO8PAGiK8eaYKGFG1bHKuAvoDoF7WXJ3FHxuWqLnKEt4dfOLm5pAe3zq1Lt6q8azT9i
 QWGpSAK5vQUWQHBHpiDjdPeqKZ6HiAXIIKfSmb+jrvXBqoP+D6/K7rUjG2aXiRtTIAXms9sm
 VRu7cmw=
In-Reply-To: <34758556-D3D0-42C3-9A1B-CBF64336ADBC@justatheory.com>
Archived-At: 
 <https://www.postgresql.org/message-id/88a392fd-d732-45a7-bcfc-291258849fbe%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------xQ3EypWBR83lZYAIGHJHJjIA
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2026-03-28 Sa 11:58 AM, David E. Wheeler wrote:
> On Mar 28, 2026, at 11:02, Andrew Dunstan<andrew@dunslane.net> wrote:
>
>> The key_name production is what allows a keyword to also be used as an object key in $.keyname syntax. The trim keywords (ltrim, rtrim, btrim) were added there, so $.ltrim as a key works. But $.lower,
>> $.upper, $.initcap, $.replace, and $.split_part as keys would all break.
> Ooh, right. It has been so long since I looked at this stuff that I forgot. Thanks for the reminder.
>
>> There are tests added for it.
> And for this!
>


Committed.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

--------------xQ3EypWBR83lZYAIGHJHJjIA
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 2026-03-28 Sa 11:58 AM, David E.
      Wheeler wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:34758556-D3D0-42C3-9A1B-CBF64336ADBC@justatheory.com">
      <pre wrap="" class="moz-quote-pre">On Mar 28, 2026, at 11:02, Andrew Dunstan <a class="moz-txt-link-rfc2396E" href="mailto:andrew@dunslane.net">&lt;andrew@dunslane.net&gt;</a> wrote:

</pre>
      <blockquote type="cite">
        <pre wrap="" class="moz-quote-pre">The key_name production is what allows a keyword to also be used as an object key in $.keyname syntax. The trim keywords (ltrim, rtrim, btrim) were added there, so $.ltrim as a key works. But $.lower,
$.upper, $.initcap, $.replace, and $.split_part as keys would all break.
</pre>
      </blockquote>
      <pre wrap="" class="moz-quote-pre">
Ooh, right. It has been so long since I looked at this stuff that I forgot. Thanks for the reminder.

</pre>
      <blockquote type="cite">
        <pre wrap="" class="moz-quote-pre">There are tests added for it.
</pre>
      </blockquote>
      <pre wrap="" class="moz-quote-pre">
And for this!

</pre>
    </blockquote>
    <p><br>
    </p>
    <p><br>
    </p>
    <p>Committed.</p>
    <p><br>
    </p>
    <p>cheers</p>
    <p><br>
    </p>
    <p>andrew<span style="white-space: pre-wrap">
</span></p>
    <pre class="moz-signature"
    signature-switch-id="d0437855-2267-4610-80b3-83167ec45b0b" cols="72">--
Andrew Dunstan
EDB: <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com">https://www.enterprisedb.com</a>
</pre>
  </body>
</html>

--------------xQ3EypWBR83lZYAIGHJHJjIA--